Skip to content

Commit

Permalink
Remove passing of --debugger-module-names flag to frontend server
Browse files Browse the repository at this point in the history
The flag is true by default so the behavior does not change.

Next steps:

Use the flag for updated debugger module names:
  - Frontend server: make the current behavior controlled
    by the flag non-conditional
  - Frontend server: add more debugging names changes under
    the same flag, false by default
  - Dwds: make changes required for the new module names.
  - Flutter tools: when matching dwds changes roll to flutter,
    pass the flag to the frontend server again.

- Cleanup:
  - Frontend server: make new behavior default
  - Flutter tools: remove uses of the flag.
  - Frontend server: remove the flag.

Towards: dart-lang/webdev#1692
Helps: flutter#106727
  • Loading branch information
Anna Gringauze committed Aug 18, 2022
1 parent 53e4664 commit c988ccf
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 6 deletions.
4 changes: 0 additions & 4 deletions packages/flutter_tools/lib/src/compile.dart
Original file line number Diff line number Diff line change
Expand Up @@ -753,10 +753,6 @@ class DefaultResidentCompiler implements ResidentCompiler {
if (testCompilation)
'--no-print-incremental-dependencies',
'--target=$targetModel',
// TODO(zanderso): remove once this becomes the default behavior
// in the frontend_server.
// https://github.com/flutter/flutter/issues/52693
'--debugger-module-names',
// TODO(annagrin): remove once this becomes the default behavior
// in the frontend_server.
// https://github.com/flutter/flutter/issues/59902
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -521,7 +521,7 @@ class ResidentWebRunner extends ResidentRunner {
final Chromium chrome = await _chromiumLauncher!.connectedInstance;
final ChromeTab chromeTab = await (chrome.chromeConnection.getTab((ChromeTab chromeTab) {
return !chromeTab.url.startsWith('chrome-extension');
}) as FutureOr<ChromeTab>);
}, retryFor: const Duration(seconds: 5)) as FutureOr<ChromeTab>);
if (chromeTab == null) {
throwToolExit('Failed to connect to Chrome instance.');
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,6 @@ void main() {
'sdkroot/',
'--incremental',
'--target=flutter',
'--debugger-module-names',
'--experimental-emit-debug-metadata',
'--output-dill',
'/build/',
Expand Down

0 comments on commit c988ccf

Please sign in to comment.