-
Notifications
You must be signed in to change notification settings - Fork 432
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Åland should not be included on countries list #36
Comments
Well, it is a god point. But this library was mainly created based on ISO codes and Åland has own one, even has own TLD ( Maybe we could make it work with additional param, like we have for |
I understand but module is named "countries" not "ISO codes" :). Filtering could be great but i think that list should not contain this as country. |
It's not "independent" - it's autonomous, with its own language (Swedish). Removing this would reduce the effectiveness of this library. I'd strongly recommend against it. |
Not gonna remove anything, on the contrary — plan to extend the library in a way features like this can be determined if required :) And as always, different purpose builds will help with effective traffic/data usage. |
I'm thinking maybe we should add a |
But from the other hand, adding this immediately brings politics up (cases like Taiwan). |
@dmythro , good point. I think possibility easy include / exclude / move it's only solution to solve these issues. I don't think you can avoid politics at all here. |
Åland it's an independent territory part of Finland but not considered as country
The text was updated successfully, but these errors were encountered: