Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Åland should not be included on countries list #36

Closed
Tracked by #135
michalzubkowicz opened this issue Jan 18, 2019 · 7 comments · Fixed by #135
Closed
Tracked by #135

Åland should not be included on countries list #36

michalzubkowicz opened this issue Jan 18, 2019 · 7 comments · Fixed by #135
Assignees
Labels

Comments

@michalzubkowicz
Copy link

Åland it's an independent territory part of Finland but not considered as country

@dmythro
Copy link
Member

dmythro commented Jan 21, 2019

Well, it is a god point. But this library was mainly created based on ISO codes and Åland has own one, even has own TLD (AX, .ax).

Maybe we could make it work with additional param, like we have for rtl in languages, so it can be filtered out easily if required?

@michalzubkowicz
Copy link
Author

I understand but module is named "countries" not "ISO codes" :).

Filtering could be great but i think that list should not contain this as country.

@matthias-b
Copy link

It's not "independent" - it's autonomous, with its own language (Swedish). Removing this would reduce the effectiveness of this library. I'd strongly recommend against it.

@dmythro
Copy link
Member

dmythro commented Nov 28, 2019

Not gonna remove anything, on the contrary — plan to extend the library in a way features like this can be determined if required :)

And as always, different purpose builds will help with effective traffic/data usage.

@dmythro
Copy link
Member

dmythro commented Mar 22, 2021

I'm thinking maybe we should add a parent, or partOf property to each country code, for cases like this (parent: "FI"). When the property exists, it means this entity is a part of another (and easy to filter in cases you really need to).
@matthias-b @michalzubkowicz

@dmythro
Copy link
Member

dmythro commented Mar 22, 2021

But from the other hand, adding this immediately brings politics up (cases like Taiwan).
And need official data for all sub-entities.

@michalzubkowicz
Copy link
Author

@dmythro , good point. I think possibility easy include / exclude / move it's only solution to solve these issues. I don't think you can avoid politics at all here.

@dmythro dmythro linked a pull request Mar 4, 2024 that will close this issue
4 tasks
dmythro added a commit that referenced this issue Mar 4, 2024
* Bump modules

* Update types and data for cases like #36 and #132

* Update comments in types.ts

* Update phone code for Kazakhstan to just `7` #134

* Case insensitive search in getCountryCode function #131

* Rebuild dist data
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants