Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to TypeScript #83

Merged
merged 33 commits into from
Jan 2, 2022
Merged

Move to TypeScript #83

merged 33 commits into from
Jan 2, 2022

Conversation

dmythro
Copy link
Member

@dmythro dmythro commented Mar 7, 2021

Move everything to TypeScript. Type-safe, awesome auto-complete for IDE.

image

image

image

image

  • Add TypeScript to project
  • Move main to TypeScript (index.ts)
  • Configure Rollup
  • Remove full data file
  • Move scripts to TypeScript
    • Minify JSON
    • Generate CSV
    • Generate SQL
    • Generate ES5 export with .d.ts
    • Update ES5 export tests
    • Generate emoji for countries
    • Generate minimal files
  • Fix main test
  • Remove Gulp

Rework

  • Rework currency codes (comma-separated string to array of codes)
  • Rework phone codes (comma-separated string to array of codes)
  • Rework continent codes (support transcontinental countries)
  • Introduce extra modules
    • Country Emoji module
    • 2to3, 3to2 module

@dmythro dmythro self-assigned this Mar 10, 2021
@dmythro dmythro mentioned this pull request Mar 11, 2021
@dmythro dmythro linked an issue Mar 11, 2021 that may be closed by this pull request
@seanonthenet
Copy link

This is super needed! Is it still WIP?

@dmythro
Copy link
Member Author

dmythro commented Dec 22, 2021

This is super needed! Is it still WIP?

I'm going to finish / release it next days. Finally a vacation!

@seanonthenet
Copy link

seanonthenet commented Dec 22, 2021

Awesome :) 👍

@dmythro dmythro marked this pull request as ready for review January 2, 2022 19:18
@dmythro dmythro merged commit dee0d94 into master Jan 2, 2022
@dmythro dmythro deleted the typescript branch January 2, 2022 19:28
@dmythro
Copy link
Member Author

dmythro commented Jan 2, 2022

Merging this to master, but some rework is still probably required to release v3. Will review this once again and make separate PRs instead of pushing to the same already huge one.

@seanonthenet
Copy link

🔥🔥🔥

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment