-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ANSI rendering of rst markup. #24
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -5,4 +5,4 @@ universal=1 | |
source=defopt | ||
|
||
[coverage:report] | ||
fail_under=98 | ||
fail_under=97 | ||
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -19,12 +19,13 @@ | |
install_requires=[ | ||
'docutils', | ||
'sphinxcontrib-napoleon>=0.5.1', | ||
'funcsigs;python_version<"3"', | ||
'funcsigs;python_version<"3.3"', | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. For the record, I don't intend to support 3.0-3.2, but I don't have a problem with changing this. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I don't plan to use them either, but that's just a more convenient way to say "function signatures were introduced in 3.3" |
||
'enum34;python_version<"3.4"', | ||
'typing;python_version<"3.5"', | ||
'colorama>=0.3.4;sys.platform=="win32"', | ||
], | ||
tests_require=[ | ||
'mock;python_version<"3"', | ||
'mock;python_version<"3.3"', | ||
], | ||
classifiers=[ | ||
'Programming Language :: Python', | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why did you need to change this? I don't think your changes reduced coverage.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
return
indoesn't get exercised (and I don't think it's worth writing a test to specifically test it -- it comes straight from the upstream implementation). That's enough for dropping the coverage.