-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor ledger startup code #1231
Conversation
Use names that make more sense, such as `AbortableSpawner` instead of `Aborter`.
CI timed out :\
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great to me. Just a couple of tiny things
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice refactor, thanks!
I tried to check the windows compilation, but unfortunately, we have a unix only dependency in the wallet |
if you could just pls add a changelog (https://github.com/anoma/anoma/blob/master/CONTRIBUTING.md#opening-a-pull-request) |
done! added a changelog entry |
Moved to anoma/namada#270 anoma/namada#271 |
I have broken down the
run_aux
function into several different logical units, which should make the ledger startup code more modular and easier to reason about.This PR will help with the changes done to the eth bridge, since the latter will require even more startup logic code to manage
geth
. For the same reason, it is in conflict with #1196, so this will need to be handled.