Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ledger --time doc #1087

Merged
merged 5 commits into from
Mar 29, 2023
Merged

Ledger --time doc #1087

Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
2b53035
Improves ledger time flag help
grarco Jan 25, 2023
af1a279
Rephrase time cli help
grarco Jan 30, 2023
d8aba33
Fixes typo in ledger arg
grarco Feb 3, 2023
a56783a
Fmt
grarco Feb 3, 2023
a5d1d3b
changelog: add #1087
tzemanovic Mar 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 8 additions & 5 deletions apps/src/lib/cli.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1702,11 +1702,14 @@ pub mod args {
}

fn def(app: App) -> App {
app.arg(
NAMADA_START_TIME
.def()
.about("The start time of the ledger."),
)
app.arg(NAMADA_START_TIME.def().about(
"The start time of the ledger. Accepts a relaxed form of \
RFC3339. A space or a 'T' are accepted as the separator \
between the date and time components. Additional spaces are \
allowed between each component.\nAll of these examples are \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; only suggestion would maybe be to either use "parts" or "components" in both sentences. Something like "... the date and time components" Eh LGTM otherwise.

equivalent:\n2023-01-20T12:12:12Z\n2023-01-20 \
12:12:12Z\n2023- 01-20T12: 12:12Z",
))
}
}

Expand Down