Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tx ChainId #1106

Merged
merged 46 commits into from
Apr 13, 2023
Merged

Tx ChainId #1106

merged 46 commits into from
Apr 13, 2023

Conversation

grarco
Copy link
Collaborator

@grarco grarco commented Jan 31, 2023 •
edited
Loading

Addresses #1009

Based on #1017

Implements a ChainId field in Tx to ensure that a transaction is accepted only by the correct fork.

  • Adds chain_id field to struct Tx
  • Adds mempool_validate checks
  • Adds process_proposal checks
  • Unit tests

@grarco grarco mentioned this pull request Jan 31, 2023
Closed
3 tasks
@grarco
Copy link
Collaborator Author

grarco commented Feb 1, 2023

pls update wasm

grarco added a commit that referenced this pull request Feb 1, 2023
@grarco
changelog: add #1106
c644f18
@grarco grarco force-pushed the grarco/tx-chain-id branch from 7e583d2 to c644f18 Compare February 2, 2023 13:32
@grarco grarco marked this pull request as ready for review February 2, 2023 13:57
@grarco grarco requested a review from tzemanovic February 2, 2023 13:57
grarco added a commit that referenced this pull request Feb 6, 2023
@grarco
changelog: add #1106
620581b
@grarco grarco force-pushed the grarco/tx-chain-id branch from 012ef9e to 28dd325 Compare February 6, 2023 11:52
tzemanovic
tzemanovic previously approved these changes Feb 7, 2023
View reviewed changes
grarco added a commit that referenced this pull request Feb 8, 2023
@grarco
changelog: add #1106
deb3ad0
@grarco grarco force-pushed the grarco/tx-chain-id branch from 28dd325 to 38cfd35 Compare February 8, 2023 11:01
@grarco grarco mentioned this pull request Feb 8, 2023
Merged
grarco added a commit that referenced this pull request Feb 10, 2023
@grarco
changelog: add #1106
2529cd2
@grarco grarco force-pushed the grarco/tx-chain-id branch from 38cfd35 to 2529cd2 Compare February 10, 2023 22:58
@grarco
Copy link
Collaborator Author

grarco commented Feb 10, 2023

pls update wasm

@grarco grarco force-pushed the grarco/tx-chain-id branch from 31ba5aa to d861a80 Compare February 10, 2023 23:26
grarco added a commit that referenced this pull request Mar 23, 2023
@grarco
changelog: add #1106
262c575
@tzemanovic tzemanovic mentioned this pull request Mar 27, 2023
Closed
grarco added a commit that referenced this pull request Mar 31, 2023
@grarco
changelog: add #1106
93def2c
tzemanovic added a commit that referenced this pull request Apr 7, 2023
@tzemanovic
Merge branch 'grarco/tx-chain-id' (#1106)
5426cff 
* grarco/tx-chain-id:
  changelog: add #1106
  [ci] wasm checksums update
  Manages invalid chain id for decrypted txs
  Adjusts decrypted tx conversion
  Clippy + fmt
  Unit tests for tx chain id
  Adjusts tx chain id check
  Validates tx `ChainId`
  Adds tx `chain_id` in tests
  Adds chain id in `Tx` instantiations
  Adds `ChainId` to struct `Tx`
tzemanovic added a commit that referenced this pull request Apr 7, 2023
@tzemanovic
evil: #1106 - update IBC VP tests chain IDs in tx construction
239d8ca
@tzemanovic tzemanovic mentioned this pull request Apr 7, 2023
Closed
@juped juped merged commit b478601 into main Apr 13, 2023
@juped juped deleted the grarco/tx-chain-id branch April 13, 2023 06:07
bengtlofgren pushed a commit that referenced this pull request May 11, 2023
@grarco @bengtlofgren
changelog: add #1106
589ee41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tzemanovic tzemanovic tzemanovic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@grarco @tzemanovic @juped