Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update masp conversions via write log #1108

Merged
merged 29 commits into from
Feb 7, 2023
Merged

update masp conversions via write log #1108

merged 29 commits into from
Feb 7, 2023

Conversation

tzemanovic
Copy link
Member

@tzemanovic tzemanovic commented Jan 31, 2023 •
edited
Loading

based on #913

This PR Improves the WlStorage to write protocol changes via block-level write log. This is then used to make sure that no storage changes are committed in ABCI FinalizeBlock request handler and only in the Commit handler.

@tzemanovic tzemanovic force-pushed the tomas/protocol-write-log branch 3 times, most recently from 24ece92 to 9441d70 Compare February 1, 2023 11:14
@tzemanovic
Copy link
Member Author

pls update wasm

tzemanovic added a commit that referenced this pull request Feb 1, 2023
@tzemanovic
changelog: add #1108
da5a58b
tzemanovic and others added 20 commits February 1, 2023 17:51
@tzemanovic
core/storage: add a warning to iter_prefix
62ab0f5
@brentstone @tzemanovic
move write_log
077291f
@tzemanovic
shared: Add WlStorage, combining WriteLog with Storage
a1284af
@tzemanovic
write_log: add prefix iter
59d69f4
@tzemanovic
write_log: allow to commit genesis txs
42d6df4
@tzemanovic
storage: rename fn commit to commit_block
6717108
@tzemanovic
storage: extend iter_prefix test
21ecedf
@tzemanovic
test/vm_host_env: fix expected keys in VP iter prefix
b71e22b 
The expected keys previously omitted a newly written value, because
iter prefix wasn't able to find it
@tzemanovic
vp_host_fns: fix has_key_pre to see keys from prev txs (not yet in DB)
326ebee
@tzemanovic
make -C wasm_for_tests/wasm_source
ff7e247
@tzemanovic
core: remove storage_api StorageRead and StorageWrite from Storage
866338d 
To use storage_api, use WlStorage instead
@tzemanovic
use WlStorage in Shell and in queries RequestCtx
bb7d173
@tzemanovic
use storage PrefixIter instead of DB iterator that respects write log
0f7779e
@tzemanovic
tests: update tests to use WlStorage
9657c74
@yito88 @tzemanovic
fix IBC VP tests
cd24137
@brentstone @tzemanovic
fix documentation
e18afde
@tzemanovic
changelog: add #913
1bcfb71
@github-actions
[ci] wasm checksums update
c317e41
@tzemanovic
test/ledger/shell: test that finalize_block doesn't commit storage
53af6ee
@tzemanovic
wl_storage: apply protocol write log changes at block level
517040d
tzemanovic added a commit that referenced this pull request Feb 1, 2023
@tzemanovic
changelog: add #1108
27ea90b
@tzemanovic tzemanovic force-pushed the tomas/protocol-write-log branch from da5a58b to 27ea90b Compare February 1, 2023 18:27
@tzemanovic tzemanovic marked this pull request as ready for review February 1, 2023 18:27
@tzemanovic tzemanovic requested a review from juped February 1, 2023 18:29
@tzemanovic
Copy link
Member Author

pls update wasm

tzemanovic
tzemanovic commented Feb 2, 2023
View reviewed changes
Copy link
Member Author

@tzemanovic tzemanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @yito88 for pointing out that there are possible storage write from goverance proposal that are committed directly to DB

@tzemanovic tzemanovic marked this pull request as draft February 2, 2023 09:41
tzemanovic added a commit that referenced this pull request Feb 2, 2023
@tzemanovic
changelog: add #1108
76bc07c
@tzemanovic tzemanovic force-pushed the tomas/protocol-write-log branch from dc9ceb9 to 76bc07c Compare February 2, 2023 13:03
@tzemanovic
Copy link
Member Author

thanks @yito88 for pointing out that there are possible storage write from goverance proposal that are committed directly to DB

I added the fix for gov - I've moved the gov module from tx_prelude into core/ledger/storage_api to make it re-usable and extended the test case to cover proposals with it.

@tzemanovic tzemanovic force-pushed the tomas/protocol-write-log branch from 76bc07c to 17427fa Compare February 2, 2023 14:10
@tzemanovic
Copy link
Member Author

pls update wasm

@tzemanovic tzemanovic marked this pull request as ready for review February 2, 2023 16:01
@tzemanovic tzemanovic mentioned this pull request Feb 2, 2023
Merged
@juped juped merged commit d1260e6 into main Feb 7, 2023
@juped juped deleted the tomas/protocol-write-log branch February 7, 2023 01:49
juped added a commit that referenced this pull request Feb 10, 2023
@juped
Merge branch 'tomas/protocol-write-log' (#1108) into maint-0.13
e1d428a 
* tomas/protocol-write-log:
  [ci] wasm checksums update
  changelog: add #1108
  shell/queries: refactor token query using storage_api token mod
  shell/gov: apply changes via `WlStorage` write log
  test/finalize_block: ensure that proposal doesn't commit to DB
  gov + token: refactor using storage_api
  move gov mod from tx_prelude to core storage_api
  test/test_vp_host_env: update to write via tx
  ledger: apply `update_allowed_conversions` storage changes via WlStorage
  wl_storage: apply protocol write log changes at block level
  test/ledger/shell: test that `finalize_block` doesn't commit storage
bengtlofgren pushed a commit that referenced this pull request May 11, 2023
@tzemanovic @bengtlofgren
changelog: add #1108
d6792f6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juped juped Awaiting requested review from juped

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tzemanovic @juped @brentstone @yito88