-
Notifications
You must be signed in to change notification settings - Fork 992
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lazy collections with Address
#1212
Conversation
915b5c5
to
cc44836
Compare
pls update wasm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks :)
* tomas/nested-lazy-vec-iter: changelog: add #1218 [ci] wasm checksums update core/storage_api/lazy_map: fix `iter` for map with nested collections core/storage_api/collections: add `is_data_sub_key` helper method core/storage_api: add predicate filtering version of prefix_iter test/lazy_vec: add test case to reproduce nested collection iter issue changelog: add #1212 [ci] wasm checksums update core/lazy_vec: test and fix for address values core/lazy_set: test and fix for address sub-key core/lazy_map: test and fix for address sub-key
The tests in here break in combination with #1141 included in 0.14.2 release - so will this rebase and fix it |
5a1374d
to
4abfd43
Compare
4abfd43
to
5115320
Compare
pls update wasm |
257c4d1
to
a1fbe9b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
* tomas/lazy-collection-sub-key: [ci] wasm checksums update changelog: add #1212 core/wl_storage: remove unnecessary alloc core/lazy_vec: test and fix for address values core/lazy_set: test and fix for address sub-key core/lazy_map: test and fix for address sub-key
based on #1256
#1196fixes #1211