Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lazy collections with Address #1212

Merged
merged 10 commits into from
Apr 13, 2023
Merged

lazy collections with Address #1212

merged 10 commits into from
Apr 13, 2023

Conversation

tzemanovic
Copy link
Member

@tzemanovic tzemanovic commented Mar 13, 2023

based on #1256 #1196

fixes #1211

@tzemanovic tzemanovic force-pushed the tomas/lazy-collection-sub-key branch from 915b5c5 to cc44836 Compare March 13, 2023 08:36
@tzemanovic
Copy link
Member Author

pls update wasm

tzemanovic added a commit that referenced this pull request Mar 13, 2023
@tzemanovic tzemanovic marked this pull request as ready for review March 13, 2023 09:18
@tzemanovic tzemanovic requested a review from brentstone March 13, 2023 10:03
brentstone
brentstone previously approved these changes Mar 15, 2023
Copy link
Collaborator

@brentstone brentstone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks :)

brentstone added a commit that referenced this pull request Mar 20, 2023
* tomas/nested-lazy-vec-iter:
  changelog: add #1218
  [ci] wasm checksums update
  core/storage_api/lazy_map: fix `iter` for map with nested collections
  core/storage_api/collections: add `is_data_sub_key` helper method
  core/storage_api: add predicate filtering version of prefix_iter
  test/lazy_vec: add test case to reproduce nested collection iter issue
  changelog: add #1212
  [ci] wasm checksums update
  core/lazy_vec: test and fix for address values
  core/lazy_set: test and fix for address sub-key
  core/lazy_map: test and fix for address sub-key
brentstone pushed a commit that referenced this pull request Mar 22, 2023
@tzemanovic
Copy link
Member Author

The tests in here break in combination with #1141 included in 0.14.2 release - so will this rebase and fix it

@tzemanovic tzemanovic marked this pull request as draft March 28, 2023 08:22
tzemanovic added a commit that referenced this pull request Mar 28, 2023
@tzemanovic tzemanovic force-pushed the tomas/lazy-collection-sub-key branch from 5a1374d to 4abfd43 Compare March 28, 2023 09:14
tzemanovic added a commit that referenced this pull request Mar 29, 2023
@tzemanovic tzemanovic force-pushed the tomas/lazy-collection-sub-key branch from 4abfd43 to 5115320 Compare March 29, 2023 05:30
@tzemanovic tzemanovic marked this pull request as ready for review March 29, 2023 05:32
@tzemanovic
Copy link
Member Author

pls update wasm

@tzemanovic
Copy link
Member Author

The tests in here break in combination with #1141 included in 0.14.2 release - so will this rebase and fix it

This is done (the last failed e2e test is unrelated - to be fixed in #1246 and #1258)

@brentstone brentstone force-pushed the tomas/lazy-collection-sub-key branch from 257c4d1 to a1fbe9b Compare March 29, 2023 16:12
Copy link
Collaborator

@brentstone brentstone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

tzemanovic added a commit that referenced this pull request Apr 11, 2023
* tomas/lazy-collection-sub-key:
  [ci] wasm checksums update
  changelog: add #1212
  core/wl_storage: remove unnecessary alloc
  core/lazy_vec: test and fix for address values
  core/lazy_set: test and fix for address sub-key
  core/lazy_map: test and fix for address sub-key
@tzemanovic tzemanovic mentioned this pull request Apr 11, 2023
@juped juped merged commit fefa440 into main Apr 13, 2023
@juped juped deleted the tomas/lazy-collection-sub-key branch April 13, 2023 06:07
bengtlofgren pushed a commit that referenced this pull request May 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

validation of lazy collections with Address key/val
3 participants