apps/client/utils/init-network: avoid adding tokens to wallet twice #1362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juped
added a commit
that referenced
this pull request
May 12, 2023
…nto ray/sdk-wip * namada/tomas/init-network-dup-tokens: changelog: add #1362 apps/client/utils/init-network: avoid adding tokens to wallet twice Fixes env variable names in docs
|
for some reason, did not address issue; still prompts on first token encountered |
Ah, there are more dup inserts for the main non-validator wallet and some for validators too. Let's address this differently in #1350 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
follow-up to #1081 - the token addresses are being added twice into the wallet when running
init-network. In here it's a no-op but with #1350 changes it triggers a replace prompt which is unwanted