Stateful replay protection #1405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grarco
force-pushed
the
grarco/bugfix-replay-prepare
branch
from
c221e9b to
ae79f1b
Compare
bengtlofgren
previously approved these changes
May 19, 2023
| @@ -648,6 +651,55 @@ where | |||
| response | |||
| } | |||
|
|
|||
| /// Checks that neither the wrapper nor the inner transaction have already | |||
juped
requested changes
May 19, 2023
| replay_protection::get_tx_hash_key(&wrapper.tx_hash); | ||
| if temp_wl_storage | ||
| .has_key(&inner_hash_key) | ||
| .expect("Error while checking inner tx hash key in storage") |
There was a problem hiding this comment.
expect()s should say something like "expected [invariant you expected to hold]"
| @@ -1236,8 +1198,8 @@ mod test_process_proposal { | |||
| assert_eq!( | |||
| response[1].result.info, | |||
| format!( | |||
| "Inner transaction hash {} already in storage, replay \ | |||
| attempt", | |||
| "Transaction replay attempt: Inner transaction hash \ | |||
There was a problem hiding this comment.
if we want to rewrite strings let's do that in its own branch, not en passant
adrianbrink
previously approved these changes
May 20, 2023
juped
force-pushed
the
grarco/bugfix-replay-prepare
branch
from
ae79f1b to
1480727
Compare
juped
added a commit
that referenced
this pull request
May 20, 2023
…1405) into maint-0.15 * namada/grarco/bugfix-replay-prepare: Adds replay protection checks in prepare_proposal
juped
force-pushed
the
grarco/bugfix-replay-prepare
branch
from
6f65fe8 to
52f803c
Compare
tzemanovic
added a commit
that referenced
this pull request
May 21, 2023
Namada 0.15.4 * tag 'v0.15.4': Namada 0.15.4 changelog: add #1407 Fixes e2e tests changelog: add #1399 Tendermint consensus params settable in Namada config Updates `InternalStats` display changelog: add #1405 process_proposal: fix typos in test names prepare_proposal: add replay protection tests Adds replay protection checks in prepare_proposal Logs validation error in `process_proposal`
tzemanovic
added a commit
that referenced
this pull request
May 21, 2023
Namada 0.15.4 * tag 'v0.15.4': Namada 0.15.4 changelog: add #1407 Fixes e2e tests changelog: add #1399 Tendermint consensus params settable in Namada config Updates `InternalStats` display changelog: add #1405 process_proposal: fix typos in test names prepare_proposal: add replay protection tests Adds replay protection checks in prepare_proposal Logs validation error in `process_proposal`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements stateful replay protection in
prepare_proposalto avoid adding the same transaction more than once in a block