Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sdk minor fixes #1409

Closed
wants to merge 5 commits into from
Closed

sdk minor fixes #1409

wants to merge 5 commits into from

Conversation

tzemanovic
Copy link
Member

@tzemanovic tzemanovic commented May 20, 2023 •
edited
Loading

follow-up to #925

couple small fixes for issues @karbyshev spotted:

  • remove empty keys mod
  • add missing cli args defs
  • fixing to print out a check error in tx submit_validator_commission_change even when --force is used
  • some typos
  • rename common args::Tx tx_code_path that's been repurposed to for tx_reveal_pk

@tzemanovic tzemanovic marked this pull request as ready for review May 20, 2023 16:01
karbyshev
karbyshev approved these changes May 20, 2023
View reviewed changes
Copy link
Contributor

@karbyshev karbyshev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@juped juped self-requested a review May 20, 2023 18:43
juped
juped requested changes May 20, 2023
View reviewed changes
Copy link
Member

@juped juped left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's split this into 5 or so branches

@tzemanovic
Copy link
Member Author

separated in #1431, #1432, #1434, #1435, #1436

@tzemanovic tzemanovic closed this May 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juped juped juped requested changes

@karbyshev karbyshev karbyshev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tzemanovic @juped @karbyshev