Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update tendermint config v2 #1570

Closed
wants to merge 14 commits into from
Closed

Conversation

Fraccaman
Copy link
Member

@Fraccaman Fraccaman commented Jun 15, 2023

Based on #1476 and #1483.

closes #1577

@Fraccaman Fraccaman requested a review from tzemanovic June 15, 2023 09:12
@Fraccaman Fraccaman force-pushed the fraccaman+adrian/tendermint-config branch from f5b452f to 06f6710 Compare June 15, 2023 12:15
Fraccaman added a commit that referenced this pull request Jun 15, 2023
* origin/fraccaman+adrian/tendermint-config:
  format
  fix: compilation errors
  added changelog
  fix: tendermint address needs port
  Fix format errors
  Fix IBC tests
  Fix clippy warnings
  Passthrough of all Tendermint config options via Namada config
  feat: switch tendermint references to cometbft
@Fraccaman Fraccaman mentioned this pull request Jun 15, 2023
@Fraccaman Fraccaman force-pushed the fraccaman+adrian/tendermint-config branch from 06f6710 to c066e35 Compare June 16, 2023 07:50
@Fraccaman Fraccaman force-pushed the fraccaman+adrian/tendermint-config branch from c066e35 to f11b12a Compare June 16, 2023 07:53
Fraccaman added a commit that referenced this pull request Jun 16, 2023
* origin/fraccaman+adrian/tendermint-config:
  cli: remove global tendermint `--mode` arg
  cli/node: remove unused tx-index argument
  added changelog
  fix: address review comments
  format
  fix: compilation errors
  fix: tendermint address needs port
  Fix format errors
  Fix IBC tests
  Fix clippy warnings
  Passthrough of all Tendermint config options via Namada config
  feat: switch tendermint references to cometbft
Fraccaman added a commit that referenced this pull request Jun 16, 2023
* origin/fraccaman+adrian/tendermint-config:
  cli: remove global tendermint `--mode` arg
  cli/node: remove unused tx-index argument
  added changelog
  fix: address review comments
  format
  fix: compilation errors
  fix: tendermint address needs port
  Fix format errors
  Fix IBC tests
  Fix clippy warnings
  Passthrough of all Tendermint config options via Namada config
  feat: switch tendermint references to cometbft
@tzemanovic
Copy link
Member

pls update wasm

tzemanovic
tzemanovic previously approved these changes Jun 16, 2023
tzemanovic
tzemanovic previously approved these changes Jun 16, 2023
@Fraccaman Fraccaman dismissed tzemanovic’s stale review June 17, 2023 11:23

The merge-base changed after approval.

@Fraccaman Fraccaman closed this Jun 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

remove tendermint_mode global arg
4 participants