[fix]: Fixed ordering for Dec and I256 types #1763
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fraccaman
added a commit
that referenced
this pull request
Jul 26, 2023
* origin/bat/fix/dec-ord: added changelog [fix]: Fixed ordering for Dec and I256 types
Closed
There was a problem hiding this comment.
Could you just describe what the difference was here? What did the .0 do?
@bengtlofgren adding .0 meant you were comparing the inner uints, and not the signed values. I think this was the source of the issue. here's an example illustrating the issue
sug0
reviewed
Jul 26, 2023
Comment on lines
+617
to
+622
| #[test] | ||
| fn test_ordering() { | ||
| let smaller = Dec::from_str("6483947304.195066085701").unwrap(); | ||
| let larger = Dec::from_str("32418116583.390243854642").unwrap(); | ||
| assert!(smaller < larger); | ||
| } |
There was a problem hiding this comment.
wouldn't this test have passed before, with the faulty comparisons?
There was a problem hiding this comment.
Nope, it needs 2 u64 words to be stored.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1762