-
Notifications
You must be signed in to change notification settings - Fork 991
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix IBC amount handling #1784
Merged
Merged
Fix IBC amount handling #1784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yito88
force-pushed
the
yuji/fix-ibc-amount
branch
from
August 8, 2023 15:26
22f47de
to
bfaa32a
Compare
yito88
force-pushed
the
yuji/fix-ibc-amount
branch
from
August 14, 2023 19:27
bfaa32a
to
37238da
Compare
yito88
force-pushed
the
yuji/fix-ibc-amount
branch
from
August 15, 2023 13:30
ba8932a
to
875b271
Compare
sug0
reviewed
Aug 16, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mostly some code style related comments/suggestions
sug0
approved these changes
Aug 16, 2023
Closed
yito88
added a commit
that referenced
this pull request
Aug 30, 2023
Fraccaman
added a commit
that referenced
this pull request
Sep 6, 2023
* origin/yuji/fix-ibc-amount: for clippy refine code add changelog for clippy fix a test add a test for receiving no token fix denom update for clippy fix tests fix amount conversion IBC transfer for non-native denom
Fraccaman
added a commit
that referenced
this pull request
Sep 6, 2023
* origin/yuji/fix-ibc-amount: for clippy refine code add changelog for clippy fix a test add a test for receiving no token fix denom update for clippy fix tests fix amount conversion IBC transfer for non-native denom
Fraccaman
added a commit
that referenced
this pull request
Sep 6, 2023
Fraccaman
added a commit
that referenced
this pull request
Sep 6, 2023
* origin/yuji/fix-ibc-amount: for clippy refine code add changelog for clippy fix a test add a test for receiving no token fix denom update for clippy fix tests fix amount conversion IBC transfer for non-native denom
Fraccaman
added a commit
that referenced
this pull request
Sep 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Closes #1744
Indicate on which release or other PRs this topic is based on
v0.21.1
Checklist before merging to
draft