Bat/new genesis

.changelog/unreleased/features/1782-pre-genesis-wallet.md

@@ -0,0 +1,7 @@
+- Added `--pre-genesis` argument to the wallet commands to allow to generate
+  keys, implicit addresses and shielded keys without having a chain setup. If
+  no chain is setup yet (i.e. there's no base-dir or it's empty), the wallet
+  defaults to use the pre-genesis wallet even without the `--pre-genesis`
+  flag. The pre-genesis wallet is located inside base-dir in
+  `pre-genesis/wallet.toml`.
+  ([#1782](https://github.com/anoma/namada/pull/1782))

.changelog/unreleased/improvements/849-human-readable-string-encoding.md

@@ -0,0 +1,2 @@
+- Added bech32m string encoding for `common::PublicKey` and `DkgPublicKey`.
+  ([#849](https://github.com/anoma/namada/pull/849))

.github/workflows/automation.yml

@@ -77,4 +77,42 @@ jobs:
         if: steps.check.outputs.triggered != 'true'
         run: echo "Comment \"$COMMENT\" not matched"
         env:
-          COMMENT: ${{ matrix.make.comment }}
+          COMMENT: ${{ matrix.make.comment }}
+
+  tasks: # tasks with commands with no external deps
+    if: ${{ github.event.issue.pull_request }}
+    runs-on: ${{ matrix.os }}
+    timeout-minutes: ${{ matrix.make.timeout }}
+    strategy:
+      fail-fast: false
+      matrix:
+        os: [ubuntu-20.04]
+        make:
+          - name: Run PoS state-machine tests
+            comment: pls run pos tests
+            command: PROPTEST_CASES=300 make test-pos-sm # PoS state machine tests
+            timeout: 600 # 10 hours
+
+    steps:
+      - uses: khan/[email protected]
+        id: check
+        with: 
+          trigger: ${{ matrix.make.comment }}
+          reaction: eyes
+        env:
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+      - uses: xt0rted/pull-request-comment-branch@v1
+        if: steps.check.outputs.triggered == 'true'
+        id: comment-branch
+      - uses: actions/checkout@v3
+        if: steps.check.outputs.triggered == 'true'
+        with:
+          ref: ${{ steps.comment-branch.outputs.head_ref }}
+      - name: Install Protoc
+        uses: arduino/setup-protoc@v1
+        if: steps.check.outputs.triggered == 'true'
+        with:
+          repo-token: ${{ secrets.GITHUB_TOKEN }}
+      - name: Run task ${{ matrix.make.name }}
+        if: steps.check.outputs.triggered == 'true'
+        run: ${{ matrix.make.command }}

.github/workflows/build-and-test.yml

@@ -280,7 +280,7 @@ jobs:
           cargo-cache
 
   run-benchmarks:
-    runs-on: 
+    runs-on:
       group: gians-runners
     timeout-minutes: 30
     needs: [build-wasm]

Makefile

@@ -51,16 +51,16 @@ build-test:
 	$(cargo) +$(nightly) build --tests $(jobs)
 
 build-release:
-	NAMADA_DEV=false $(cargo) build $(jobs) --release --timings --package namada_apps --manifest-path Cargo.toml 
+	$(cargo) build $(jobs) --release --package namada_apps --manifest-path Cargo.toml
 
 build-debug:
-	NAMADA_DEV=false $(cargo) build --package namada_apps --manifest-path Cargo.toml
+	$(cargo) build --package namada_apps --manifest-path Cargo.toml
 
 install-release:
-	NAMADA_DEV=false $(cargo) install --path ./apps --locked
+	$(cargo) install --path ./apps --locked
 
 check-release:
-	NAMADA_DEV=false $(cargo) check --release --package namada_apps
+	$(cargo) check --release --package namada_apps
 
 package: build-release
 	scripts/make-package.sh
@@ -85,7 +85,7 @@ check-crates:
 clippy-wasm = $(cargo) +$(nightly) clippy --manifest-path $(wasm)/Cargo.toml --all-targets -- -D warnings
 
 clippy:
-	NAMADA_DEV=false $(cargo) +$(nightly) clippy $(jobs) --all-targets -- -D warnings && \
+	$(cargo) +$(nightly) clippy $(jobs) --all-targets -- -D warnings && \
 	make -C $(wasms) clippy && \
 	make -C $(wasms_for_tests) clippy && \
 	$(foreach wasm,$(wasm_templates),$(clippy-wasm) && ) true
@@ -100,7 +100,7 @@ tendermint:
 	./scripts/get_tendermint.sh
 
 install: cometbft
-	NAMADA_DEV=false $(cargo) install --path ./apps --locked
+	$(cargo) install --path ./apps --locked
 
 cometbft:
 	./scripts/get_cometbft.sh
@@ -163,7 +163,7 @@ test-integration-save-proofs:
 # Run integration tests without specifiying any pre-built MASP proofs option
 test-integration-slow:
 	RUST_BACKTRACE=$(RUST_BACKTRACE) \
-	$(cargo) +$(nightly) test integration::$(TEST_FILTER) \
+	$(cargo) +$(nightly) test integration::$(TEST_FILTER)  --features integration \
 	-Z unstable-options \
 	-- \
 	-Z unstable-options --report-time
@@ -217,7 +217,7 @@ test-pos-sm:
 	RUST_BACKTRACE=1 \
 		PROPTEST_CASES=$(PROPTEST_CASES) \
 		RUSTFLAGS='-C debuginfo=2 -C debug-assertions=true -C overflow-checks=true' \
-		cargo test pos_state_machine_test --release 
+		cargo test pos_state_machine_test --release
 
 fmt-wasm = $(cargo) +$(nightly) fmt --manifest-path $(wasm)/Cargo.toml
 fmt:

README.md

@@ -46,10 +46,6 @@ Guide.
 ```shell
 # Build the provided validity predicate and transaction wasm modules
 make build-wasm-scripts-docker
-
-# Development (debug) build Namada, which includes a validator and some default 
-# accounts, whose keys and addresses are available in the wallet
-NAMADA_DEV=true make
 ```
 
 ### Before submitting a PR, pls make sure to run the following

apps/Cargo.toml

@@ -54,11 +54,11 @@ default = ["std", "abciplus"]
 mainnet = [
   "namada/mainnet",
 ]
-dev = ["namada/dev"]
 std = ["ed25519-consensus/std", "rand/std", "rand_core/std", "namada/std"]
 # for integration tests and test utilies
-testing = ["dev"]
-
+testing = []
+benches = ["testing", "namada_test_utils"]
+integration = []
 abciplus = [
     "namada/abciplus",
     "namada/tendermint-rpc",
@@ -67,6 +67,7 @@ abciplus = [
 
 [dependencies]
 namada = {path = "../shared", features = ["ferveo-tpke", "masp-tx-gen", "multicore", "http-client"]}
+namada_test_utils = {path = "../test_utils", optional = true}
 ark-serialize.workspace = true
 ark-std.workspace = true
 arse-merkle-tree = { workspace = true, features = ["blake2b"] }
@@ -108,6 +109,7 @@ num-rational.workspace = true
 num-traits.workspace = true
 once_cell.workspace = true
 orion.workspace = true
+pretty_assertions.workspace = true
 prost-types.workspace = true
 prost.workspace = true
 rand_core.workspace = true

apps/build.rs

@@ -53,13 +53,4 @@ fn main() {
 
     // Tell Cargo that if the given file changes, to rerun this build script.
     println!("cargo:rerun-if-changed={}", PROTO_SRC);
-
-    // Tell Cargo to build when the `NAMADA_DEV` env var changes
-    println!("cargo:rerun-if-env-changed=NAMADA_DEV");
-    // Enable "dev" feature if `NAMADA_DEV` is trueish
-    if let Ok(dev) = env::var("NAMADA_DEV") {
-        if dev.to_ascii_lowercase().trim() == "true" {
-            println!("cargo:rustc-cfg=feature=\"dev\"");
-        }
-    }
 }

apps/src/bin/namada-node/cli.rs

@@ -10,26 +10,31 @@ pub fn main() -> Result<()> {
     match cmd {
         cmds::NamadaNode::Ledger(sub) => match sub {
             cmds::Ledger::Run(cmds::LedgerRun(args)) => {
-                let wasm_dir = ctx.wasm_dir();
+                let chain_ctx = ctx.take_chain_or_exit();
+                let wasm_dir = chain_ctx.wasm_dir();
                 sleep_until(args.start_time);
-                ledger::run(ctx.config.ledger, wasm_dir);
+                ledger::run(chain_ctx.config.ledger, wasm_dir);
             }
             cmds::Ledger::RunUntil(cmds::LedgerRunUntil(args)) => {
-                let wasm_dir = ctx.wasm_dir();
+                let mut chain_ctx = ctx.take_chain_or_exit();
+                let wasm_dir = chain_ctx.wasm_dir();
                 sleep_until(args.time);
-                ctx.config.ledger.shell.action_at_height =
+                chain_ctx.config.ledger.shell.action_at_height =
                     Some(args.action_at_height);
-                ledger::run(ctx.config.ledger, wasm_dir);
+                ledger::run(chain_ctx.config.ledger, wasm_dir);
             }
             cmds::Ledger::Reset(_) => {
-                ledger::reset(ctx.config.ledger)
+                let chain_ctx = ctx.take_chain_or_exit();
+                ledger::reset(chain_ctx.config.ledger)
                     .wrap_err("Failed to reset Namada node")?;
             }
             cmds::Ledger::DumpDb(cmds::LedgerDumpDb(args)) => {
-                ledger::dump_db(ctx.config.ledger, args);
+                let chain_ctx = ctx.take_chain_or_exit();
+                ledger::dump_db(chain_ctx.config.ledger, args);
             }
             cmds::Ledger::RollBack(_) => {
-                ledger::rollback(ctx.config.ledger)
+                let chain_ctx = ctx.take_chain_or_exit();
+                ledger::rollback(chain_ctx.config.ledger)
                     .wrap_err("Failed to rollback the Namada node")?;
             }
         },
@@ -39,18 +44,18 @@ pub fn main() -> Result<()> {
                 // In here, we just need to overwrite the default chain ID, in
                 // case it's been already set to a different value
                 if let Some(chain_id) = ctx.global_args.chain_id.as_ref() {
-                    ctx.global_config.default_chain_id = chain_id.clone();
+                    ctx.global_config.default_chain_id = Some(chain_id.clone());
                     ctx.global_config
                         .write(&ctx.global_args.base_dir)
                         .unwrap_or_else(|err| {
-                            eprintln!("Error writing global config: {}", err);
+                            eprintln!("Error writing global config: {err}");
                             cli::safe_exit(1)
                         });
+                    tracing::debug!(
+                        "Generated config and set default chain ID to \
+                         {chain_id}"
+                    );
                 }
-                tracing::debug!(
-                    "Generated config and set default chain ID to {}",
-                    &ctx.global_config.default_chain_id
-                );
             }
         },
     }

apps/src/bin/namada/cli.rs

@@ -63,7 +63,7 @@ fn handle_command(cmd: cli::cmds::Namada, raw_sub_cmd: String) -> Result<()> {
 fn handle_subcommand(program: &str, mut sub_args: Vec<String>) -> Result<()> {
     let env_vars = env::vars_os();
 
-    let cmd_name = if cfg!(feature = "dev") && env::var("CARGO").is_ok() {
+    let cmd_name = if env::var("CARGO").is_ok() {
         // When the command is ran from inside `cargo run`, we also want to
         // call the sub-command via `cargo run` to rebuild if necessary.
         // We do this by prepending the arguments with `cargo run` arguments.