fix and check namada_benchmarks crate build with default features #1906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grarco
previously approved these changes
Sep 20, 2023
|
I think we can also change this step of the Makefile: check:
$(cargo) check --workspace --exclude namada_benchmarks && \
$(cargo) +$(nightly) check --benches && \to just be check:
$(cargo) check && \ |
grarco
approved these changes
Sep 22, 2023
tzemanovic
added a commit
that referenced
this pull request
Sep 25, 2023
* tomas/check-benchmarks-crate: make: refactor `make check` fix and check namada_benchmarks crate build with default features
Closed
Fraccaman
added a commit
that referenced
this pull request
Sep 25, 2023
* origin/tomas/check-benchmarks-crate: make: refactor `make check` fix and check namada_benchmarks crate build with default features
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Enables to e.g.
cd benches && cargo test --bencheswith default featuresIndicate on which release or other PRs this topic is based on
0.22.0
Checklist before merging to
draft[ ] I have added a changelog