Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Query for IBC tokens #1951

Merged
merged 4 commits into from
Oct 24, 2023
Merged

Query for IBC tokens #1951

merged 4 commits into from
Oct 24, 2023

Conversation

yito88
Copy link
Member

@yito88 yito88 commented Sep 27, 2023 •
edited
Loading

Describe your changes

closes #1946

  • Transfer (transfer and ibc-transfer) with a token prefixed with IBC trace-path for IBC token instead of the raw address. 
    $ namadac transfer \
    --amount 100 \
    --source albert \
    --target bertha \
    --token transfer/channel-0/nam \
    --signing-keys albert-key
  • Balance query checks also IBC tokens and shows the alias instead of the raw addresses 
    $ namadac balance --token nam --owner albert
nam: 1000000
transfer/channel-0/nam: 50000

$ namadac balance --owner albert
apfel: 1000000
btc: 1000000
dot: 1000000
eth: 1000000
kartoffel: 1000000
nam: 1000000
schnitzel: 1000000
transfer/channel-0/nam: 50000

Indicate on which release or other PRs this topic is based on

v0.23.0

Checklist before merging to draft

  • I have added a changelog
  • Git history is in acceptable state

@yito88 yito88 requested review from Fraccaman and sug0 September 28, 2023 09:51
@yito88 yito88 marked this pull request as ready for review September 28, 2023 09:51
@yito88 yito88 mentioned this pull request Sep 29, 2023
Merged
2 tasks
sug0
sug0 reviewed Oct 2, 2023
View reviewed changes
apps/src/lib/cli.rs Outdated Show resolved Hide resolved
apps/src/lib/client/rpc.rs Outdated Show resolved Hide resolved
@yito88 yito88 requested a review from sug0 October 2, 2023 20:43
@Fraccaman Fraccaman mentioned this pull request Oct 16, 2023
Closed
yito88 added a commit that referenced this pull request Oct 17, 2023
@yito88
Merge branch 'yuji/ibc-balance-query' (#1951)
b301581
@cwgoes cwgoes mentioned this pull request Oct 20, 2023
Closed
23 tasks
Fraccaman added a commit that referenced this pull request Oct 23, 2023
@Fraccaman
Merge branch 'yuji/ibc-balance-query' (#1951)
2657618 
* origin/yuji/ibc-balance-query:
  remove trace-path
  add changelog
  query balances for IbcToken
  transfer and query with trace-path
tzemanovic added a commit that referenced this pull request Oct 24, 2023
@tzemanovic
Merge branch 'yuji/ibc-balance-query' (#1951)
ed3cb64 
* origin/yuji/ibc-balance-query:
  remove trace-path
  add changelog
  query balances for IbcToken
  transfer and query with trace-path
@tzemanovic tzemanovic mentioned this pull request Oct 24, 2023
Merged
@tzemanovic tzemanovic merged commit b874ffa into main Oct 24, 2023
@tzemanovic tzemanovic deleted the yuji/ibc-balance-query branch October 24, 2023 11:26
brentstone pushed a commit that referenced this pull request Nov 11, 2023
@tzemanovic @brentstone
Merge branch 'yuji/ibc-balance-query' (#1951)
97a5372 
* origin/yuji/ibc-balance-query:
  remove trace-path
  add changelog
  query balances for IbcToken
  transfer and query with trace-path
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sug0 sug0 sug0 approved these changes

@Fraccaman Fraccaman Awaiting requested review from Fraccaman

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Query balances for IBC tokens
3 participants
@yito88 @sug0 @tzemanovic