avoid enabling "testing" feature in workspace from benches #1955
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
grarco
approved these changes
Sep 28, 2023
Closed
tzemanovic
added a commit
that referenced
this pull request
Oct 18, 2023
* origin/tomas/avoid-testing-feature-in-workspace: changelog: add #1955 benches: rm unused deps benches: update docs benches: move bench lib code to apps crate and feature guard it
Fraccaman
added a commit
that referenced
this pull request
Oct 23, 2023
* origin/tomas/avoid-testing-feature-in-workspace: changelog: add #1955 benches: rm unused deps benches: update docs benches: move bench lib code to apps crate and feature guard it
tzemanovic
added a commit
that referenced
this pull request
Oct 24, 2023
* origin/tomas/avoid-testing-feature-in-workspace: changelog: add #1955 benches: rm unused deps benches: update docs benches: move bench lib code to apps crate and feature guard it
Merged
brentstone
pushed a commit
that referenced
this pull request
Nov 11, 2023
* origin/tomas/avoid-testing-feature-in-workspace: changelog: add #1955 benches: rm unused deps benches: update docs benches: move bench lib code to apps crate and feature guard it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
The changes from #1907 inadvertently affected the whole workspace as benches have non-dev dependency on
namadaandnamada_appswith"testing"feature on, which in turn enables the"dev"feature. This means that in 0.23.0 building from the root would switch on these features by default even for the build of the binaries (e.g.cargo buildorcargo run)."testing"feature into namada_apps crate and feature-guard it with the same feature"testing". This allowed to switch all the[dependencies]in benches to[dev-dependencies]and so the workspace build is no longer affected by these.Indicate on which release or other PRs this topic is based on
0.23.0
Checklist before merging to
draft