Outdated Ethereum event nonce fixes #2035
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sug0
force-pushed
the
tiago/outdated-eth-nonces
branch
from
c4a5e76 to
4dbc621
Compare
tzemanovic
approved these changes
Oct 24, 2023
batconjurer
approved these changes
Oct 27, 2023
Closed
Closed
tzemanovic
added a commit
that referenced
this pull request
Nov 28, 2023
* origin/tiago/outdated-eth-nonces: Changelog for #2035 Test eth events with outdated nonces during ProcessProposal Test eth events with outdated nonces during PrepareProposal Test eth events with outdated nonces during CheckTx Test replaying eth events with outdated nonces Fix unit tests Only propose eth events with up to date nonces Disregard state updates from eth events with outdated nonces Discard eth events from oracle with invalid nonces Relocate eth event nonce validation
tzemanovic
added a commit
that referenced
this pull request
Nov 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Fixes Ethereum event validation/state updates when more than one validator is running the chain.
Specifically, before this patchset, validators would reject block proposals containing vote extensions storing Ethereum events with an invalid (outdated) nonce. This would hinder in the best case the latency of Ethereum bridge operations, and in the worst case its liveness, since events with nonces that could be processed would be mixed with events with outdated nonces.
With these changes, we allow extensions with at least one good event to be processed, and ignore state updates from events with invalid nonces.
Indicate on which release or other PRs this topic is based on
v0.23.0Checklist before merging to
draft