Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rand flag for sdk #2165

Merged
merged 2 commits into from
Nov 21, 2023
Merged

Add rand flag for sdk #2165

merged 2 commits into from
Nov 21, 2023

Conversation

yito88
Copy link
Member

@yito88 yito88 commented Nov 13, 2023

Describe your changes

closes #2164

Indicate on which release or other PRs this topic is based on

0.26.0

Checklist before merging to draft

  • I have added a changelog
  • Git history is in acceptable state

@Fraccaman
Copy link
Member

should we add a CI step to test that the sdk build correctly?

@yito88
Copy link
Member Author

yito88 commented Nov 13, 2023

We should do it, I think

@Fraccaman
Copy link
Member

i think we can merge this PR toghether with #2170

Fraccaman
Fraccaman previously approved these changes Nov 14, 2023
@bengtlofgren bengtlofgren mentioned this pull request Nov 15, 2023
@yito88 yito88 mentioned this pull request Nov 15, 2023
2 tasks
@yito88 yito88 requested a review from Fraccaman November 15, 2023 14:33
adrianbrink added a commit that referenced this pull request Nov 15, 2023
* origin/yuji/fix-feature-flag:
  to be able to build sdk
  add rand flag to sdk
@tzemanovic tzemanovic merged commit a0ecf9b into main Nov 21, 2023
@tzemanovic tzemanovic deleted the yuji/fix-feature-flag branch November 21, 2023 07:57
@adrianbrink adrianbrink restored the yuji/fix-feature-flag branch November 21, 2023 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compiling namada_sdk crate failed due to no "rand"
3 participants