Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Masp miscellaneous fixes #2282

Merged
merged 28 commits into from
Dec 29, 2023
Merged

Masp miscellaneous fixes #2282

merged 28 commits into from
Dec 29, 2023

Conversation

grarco
Copy link
Collaborator

@grarco grarco commented Dec 14, 2023

Describe your changes

Removes epoch for fee unshielding from the sdk that became useless with #2222.
Removes MASP key from vp_user which is not needed.
Refactors fee unshielding tests.

Indicate on which release or other PRs this topic is based on

#2248

Checklist before merging to draft

  • I have added a changelog
  • Git history is in acceptable state

@grarco grarco marked this pull request as ready for review December 15, 2023 11:05
@grarco grarco requested a review from murisi December 15, 2023 11:05
@grarco grarco requested a review from batconjurer December 15, 2023 17:16
@grarco grarco mentioned this pull request Dec 18, 2023
grarco added a commit that referenced this pull request Dec 20, 2023
brentstone added a commit that referenced this pull request Dec 29, 2023
* origin/grarco/masp-misc-fixes:
  Changelog #2282
  Minor refactor to masp fee unshield tests
  Removes useless fee unshielding epoch
  Removes useless MASP key from `vp_user`
@brentstone brentstone merged commit ebb69bc into main Dec 29, 2023
13 of 14 checks passed
@brentstone brentstone deleted the grarco/masp-misc-fixes branch December 29, 2023 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants