rocksdb: replace recursion from prefix iterator with a loop #2325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tzemanovic
added a commit
that referenced
this pull request
Dec 21, 2023
2 tasks
tzemanovic
added a commit
that referenced
this pull request
Dec 22, 2023
brentstone
added a commit
that referenced
this pull request
Dec 22, 2023
* tomas/db-rm-recursion: fixup! changelog: add #2325 fixup! fix replay_protection iterator to avoid unmatched keys fixup! fix replay_protection iterator to avoid unmatched keys changelog: add #2325 fix replay_protection iterator to avoid unmatched keys rocksdb: warn on unmatched prefix in iterator rocksdb: replace recursion from prefix iterator with a loop ci: update mold ci: split integration and unit
brentstone
force-pushed
the
tomas/db-rm-recursion
branch
from
2377d67 to
2683a68
Compare
brentstone
added a commit
that referenced
this pull request
Dec 23, 2023
Namada 0.28.2 is a patch release that fixes a stack overflow issue for nodes. * tag 'v0.28.2': Namada 0.28.2 changelog: add #2325 fix replay_protection iterator to avoid unmatched keys rocksdb: warn on unmatched prefix in iterator rocksdb: replace recursion from prefix iterator with a loop update hermes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Also fixed replay protection prefix iterator that was causing this recursion stack size to grow with every tx. To help avoid these issues in future, I also added
tracing::warnfor when we get an unmatched prefix (which falls back to go to the next iterator item).Indicate on which release or other PRs this topic is based on
0.28.1
Checklist before merging to
draft