fix pos tx tests input lower bound #813
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tzemanovic
added a commit
that referenced
this pull request
Dec 5, 2022
* tomas/fix-pos-tx-test-input-lower-bound:
wasm/tx_unbond: add regressions file
wasm/tx_{bond,unbond,withdraw}: avoid zero-amount action for test inputs
PoS: allow 0 amount bond/unbond in tx
Closed
juped
added a commit
that referenced
this pull request
Dec 13, 2022
* tomas/fix-pos-tx-test-input-lower-bound: changelog: add #813 wasm/tx_unbond: add regressions file wasm/tx_{bond,unbond,withdraw}: avoid zero-amount action for test inputs PoS: allow 0 amount bond/unbond in tx
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
based on #708
This PR fixes an issue with generated input with zero-amount action to the tests, which were prohibited by tx logic (this is redundant, because tx is untrusted anyway). This restriction is lifted in the tx implementation (removed
ZeroAmounterror) and the tests are setup to only cover non-zero bonds/unbonds.