refactor and add more bech32m encodings #849
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tzemanovic
force-pushed
the
tomas/human-readable-string-encoding
branch
from
7933bec to
191192d
Compare
Closed
|
pls update wasm |
tzemanovic
added a commit
that referenced
this pull request
Jan 12, 2023
tzemanovic
force-pushed
the
tomas/human-readable-string-encoding
branch
from
97e147f to
d0fa606
Compare
|
pls update wasm |
tzemanovic
force-pushed
the
tomas/human-readable-string-encoding
branch
2 times, most recently
from
e510115 to
cb4cf8e
Compare
|
pls update wasm |
|
@tzemanovic Do you want to keep this open or reopen it when we are ready to merge this into the next release. |
|
@Fraccaman this has breaking changes for genesis, so let's leave it until #685 is also ready |
tzemanovic
force-pushed
the
tomas/human-readable-string-encoding
branch
from
0f7da43 to
43758d3
Compare
…ma/namada into tomas/human-readable-string-encoding
tzemanovic
force-pushed
the
tomas/human-readable-string-encoding
branch
from
099b224 to
37c0315
Compare
Closed
…ma/namada into tomas/human-readable-string-encoding * 'tomas/human-readable-string-encoding' of github.com:anoma/namada: wasm: update checksums test/e2e/ledger_tests: use bech32m PK format for `init-account` cmd core/key: add a helper to gen ed25519 key in bech32m format add `common::Signature` bech32m encoding changelog: add #849 add bech32m string encoding for `common::PublicKey` and `DkgPublicKey` refactor bech32m string encoding for address and MASP addresses
|
included in #2088 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
based on v0.14.0
Since we're doing breaking changes for genesis in #685, it's a good opportunity to add bech32m string encoding for
common::PublicKeyandDkgPublicKeyand use that for genesis instead the hexThis PR:
common::{PublicKey, Signature}andDkgPublicKey