Implement cubic slashing #892
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brentstone
force-pushed
the
brent/cubic-slashing
branch
from
a5f1d1b to
3dda1d0
Compare
brentstone
force-pushed
the
brent/cubic-slashing
branch
2 times, most recently
from
7bb827b to
de939e1
Compare
31 tasks
This was referenced Jan 13, 2023
Closed
brentstone
force-pushed
the
brent/cubic-slashing
branch
2 times, most recently
from
cb3e324 to
9602de1
Compare
brentstone
force-pushed
the
brent/cubic-slashing
branch
2 times, most recently
from
3402429 to
e6a8e3b
Compare
brentstone
force-pushed
the
brent/cubic-slashing
branch
4 times, most recently
from
d046e7f to
5e7c689
Compare
brentstone
force-pushed
the
brent/cubic-slashing
branch
5 times, most recently
from
8bd9cb4 to
aba1bcc
Compare
brentstone
force-pushed
the
brent/cubic-slashing
branch
5 times, most recently
from
8cff386 to
69f9a25
Compare
brentstone
force-pushed
the
brent/cubic-slashing
branch
from
dd0d2fe to
ecd8517
Compare
tzemanovic
reviewed
May 26, 2023
brentstone
force-pushed
the
brent/cubic-slashing
branch
from
3a0d4af to
985e822
Compare
brentstone
added a commit
that referenced
this pull request
May 27, 2023
* brent/cubic-slashing: fixup! cubic and general slashing algorithms and transactions fixup! rip slash pool changelog: #892 fixup!: don't call `process_slashes` within `advance_epoch` clean up logging fix clippy remove test code until slash pool transfers are solved rip slash pool get_slashed_amount: inclusive on infraction epoch add cli to sdk impl for tx unjail make find_slashes_in_ranges inclusive on end epoch withdraw: fix bounds for collecting slashes for an unbond aesthetic cleaning revert bound cleaning for readability refactor slash lookup fixup! add cubic_slash_window_length to bounds (maybe still needs change) remove unused cubic slash function refactor epoch offsets with params methods store total bond sums of each validator for efficient computation pos/lib.rs: WIP fix things inside of `bonds_and_unbonds` fix PoS client query related functions fix `bond_amount` state machine test: add slashing basic nested map test slashing: unit and e2e tests Makefile and Cargo.toml cubic and general slashing algorithms and transactions
brentstone
force-pushed
the
brent/cubic-slashing
branch
from
985e822 to
2bc8ec3
Compare
tzemanovic
previously approved these changes
May 28, 2023
brentstone
force-pushed
the
brent/cubic-slashing
branch
from
d712450 to
2936909
Compare
brentstone
added a commit
that referenced
this pull request
Jun 1, 2023
* brent/cubic-slashing: WIP changes from Manu and logging fixing `find_slashes_in_range` pos sm test: ease load on the CI changelog: #892 fixup!: don't call `process_slashes` within `advance_epoch` clean up logging fix clippy remove test code until slash pool transfers are solved rip slash pool get_slashed_amount: inclusive on infraction epoch add cli to sdk impl for tx unjail make find_slashes_in_ranges inclusive on end epoch withdraw: fix bounds for collecting slashes for an unbond aesthetic cleaning revert bound cleaning for readability refactor slash lookup fixup! add cubic_slash_window_length to bounds (maybe still needs change) remove unused cubic slash function refactor epoch offsets with params methods store total bond sums of each validator for efficient computation pos/lib.rs: WIP fix things inside of `bonds_and_unbonds` fix PoS client query related functions fix `bond_amount` state machine test: add slashing basic nested map test slashing: unit and e2e tests Makefile and Cargo.toml cubic and general slashing algorithms and transactions format: rustfmt for incorrect sdk-wallet-force commits changelog: add #925, update ci: remove clippy-abcipp check changelog: add #889 DoS checks in fee specs for fee unshielding Adjusts block proposer address in fee specs Improves unshielding tx verification in fee specs Updates tendermint link in fee specs Improves gas accounting in specs Updates check table in fee specs Misc updates to fee specs Fixes wal in fee specs Adds protocol transactions to fee specs Adds governance proposals to fee specs Fixes unshielding in fee specs Enforces tx type order in fee specs Refactors sections of fee specs Adds unshielding to fee specs Updates fee specs Adds fee specs
brentstone
added a commit
that referenced
this pull request
Jun 1, 2023
* brent/cubic-slashing: fix wasm tx tests WIP changes from Manu and logging fixing `find_slashes_in_range` pos sm test: ease load on the CI changelog: #892 fixup!: don't call `process_slashes` within `advance_epoch` clean up logging fix clippy remove test code until slash pool transfers are solved rip slash pool get_slashed_amount: inclusive on infraction epoch add cli to sdk impl for tx unjail make find_slashes_in_ranges inclusive on end epoch withdraw: fix bounds for collecting slashes for an unbond aesthetic cleaning revert bound cleaning for readability refactor slash lookup fixup! add cubic_slash_window_length to bounds (maybe still needs change) remove unused cubic slash function refactor epoch offsets with params methods store total bond sums of each validator for efficient computation pos/lib.rs: WIP fix things inside of `bonds_and_unbonds` fix PoS client query related functions fix `bond_amount` state machine test: add slashing basic nested map test slashing: unit and e2e tests Makefile and Cargo.toml cubic and general slashing algorithms and transactions format: rustfmt for incorrect sdk-wallet-force commits changelog: add #925, update ci: remove clippy-abcipp check changelog: add #889 DoS checks in fee specs for fee unshielding Adjusts block proposer address in fee specs Improves unshielding tx verification in fee specs Updates tendermint link in fee specs Improves gas accounting in specs Updates check table in fee specs Misc updates to fee specs Fixes wal in fee specs Adds protocol transactions to fee specs Adds governance proposals to fee specs Fixes unshielding in fee specs Enforces tx type order in fee specs Refactors sections of fee specs Adds unshielding to fee specs Updates fee specs Adds fee specs
Fraccaman
added a commit
that referenced
this pull request
Jun 5, 2023
* origin/brent/cubic-slashing: fix wasm tx tests WIP changes from Manu and logging fixing `find_slashes_in_range` pos sm test: ease load on the CI changelog: #892 fixup! cubic and general slashing algorithms and transactions fixup! rip slash pool fixup!: don't call `process_slashes` within `advance_epoch` clean up logging fix clippy remove test code until slash pool transfers are solved rip slash pool get_slashed_amount: inclusive on infraction epoch add cli to sdk impl for tx unjail make find_slashes_in_ranges inclusive on end epoch withdraw: fix bounds for collecting slashes for an unbond aesthetic cleaning revert bound cleaning for readability refactor slash lookup fixup! add cubic_slash_window_length to bounds (maybe still needs change) remove unused cubic slash function refactor epoch offsets with params methods store total bond sums of each validator for efficient computation pos/lib.rs: WIP fix things inside of `bonds_and_unbonds` fix PoS client query related functions fix `bond_amount` state machine test: add slashing basic nested map test slashing: unit and e2e tests Makefile and Cargo.toml cubic and general slashing algorithms and transactions
This was referenced Jun 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on v0.16.0
Closes #14, closes #35, closes #124, closes #789.
Note to consider for review: in the pseudocode (Informal partnership), slashes are processed at the very end of an epoch, while in Namada, they are processed at the very beginning of an epoch. This produces slightly different bounds for iteration in several places.
In order to merge into 0.17.0, the following items have been removed from the PR and will have their own PRs to integrate after:
get_slashed_amount)