Skip to content

Commit

Permalink
elb_classic_lb - deprecate the ec2_elb fact (#552)
Browse files Browse the repository at this point in the history
elb_classic_lb - deprecate the ec2_elb fact

SUMMARY
deprecates the ec2_elb fact in favour of the elb return value.
Split off from #377
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
elb_classic_lb
ADDITIONAL INFORMATION
(yes, this module set a fact with the same name, but different content, as the elb_instance module.)

Reviewed-by: Alina Buzachis <None>
Reviewed-by: None <None>
  • Loading branch information
tremble authored Oct 26, 2021
1 parent f8a830b commit 88bd86e
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 0 deletions.
3 changes: 3 additions & 0 deletions changelogs/fragments/552-elb_classic_lb-fact.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
deprecated_features:
- ec2_classic_lb - setting of the ``ec2_elb`` fact has been deprecated and will be removed in release 4.0.0 of the collection.
The module now returns ``elb`` which can be accessed using the register keyword (https://github.com/ansible-collections/amazon.aws/pull/552).
4 changes: 4 additions & 0 deletions plugins/modules/elb_classic_lb.py
Original file line number Diff line number Diff line change
Expand Up @@ -288,6 +288,10 @@
default: true
version_added: 2.1.0
notes:
- The ec2_elb fact currently set by this module has been deprecated and will no
longer be set after release 4.0.0 of the collection.
extends_documentation_fragment:
- amazon.aws.aws
- amazon.aws.ec2
Expand Down

0 comments on commit 88bd86e

Please sign in to comment.