Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kms_key - Add support for "Regionality" (multi-region keys) #1281

Closed
1 task done
jrglynn2 opened this issue Nov 21, 2022 · 3 comments · Fixed by #1290
Closed
1 task done

kms_key - Add support for "Regionality" (multi-region keys) #1281

jrglynn2 opened this issue Nov 21, 2022 · 3 comments · Fixed by #1290
Assignees
@GomathiselviS
Labels
feature This issue/PR relates to a feature request jira module module plugins plugin (any type)

Comments

@jrglynn2
Copy link
Contributor

jrglynn2 commented Nov 21, 2022 •
edited by tremble
Loading

Summary

AWS introduced Multi-Region Keys in KMS in June 2021 (https://aws.amazon.com/about-aws/whats-new/2021/06/kms-multi-region-keys/), can the aws_kms module be changed to include that option?

Per the AWS CLI, it is just a parameter of --multi-region, which translates the Boolean as True (default is False) - https://awscli.amazonaws.com/v2/documentation/api/latest/reference/kms/create-key.html

Thanks,

jrglynn2

Issue Type

Feature Idea

Component Name

kms_key

Additional Information



Would enable creation of multi-region keys - currently you cannot do so using Ansible.


Code of Conduct


    

  •  I agree to follow the Ansible Code of Conduct
    • 


      		
    

      
  





        



            

              
            

        

      


      
    








      

    



      

  
            

    

      
    

    


      

          @jrglynn2
jrglynn2




        changed the title
Add "Regionality" (multi-region keys) to aws_kms module

Add "Regionality" (multi-region keys) to aws_kms/kms_key module


      Nov 21, 2022

    

  








      

  
      



  

  @jrglynn2





  


    

      

  

    

        
    
    

  


      
          
  
      
            Copy link

  

      
    

  


  

      

  
    Contributor


      

  Author


  


  

    

  





      


        


  
    

      
          
Apparently this module was renamed, even though the Ansible Documentation site doesn't reflect it - so the module might also be named kms_key

      		
    

  





        


            

            

              
            

        

      


      

            
  

    
  
    
    

  

  



    












      

  
            

    

      
    

    


      

          @ansibullbot
ansibullbot




            added
      

  feature

  This issue/PR relates to a feature request

      

  needs_triage


  labels


      Nov 21, 2022

    

  



    

    

      
    

    


      

          @tremble
tremble




        transferred this issue from ansible-collections/community.aws


      Nov 22, 2022

    

  



    

    

      
    

    


      

          @tremble
tremble




        changed the title
Add "Regionality" (multi-region keys) to aws_kms/kms_key module

kms_key - Add support for "Regionality" (multi-region keys)


      Nov 22, 2022

    

  








      

  
      



  

  @ansibullbot





  


    

      

  

    

        
    
    

  


      
          
  
      
            Copy link

  

      
    

  


  

      



      

  


  

    

  





      


        


  
    

      
          
cc @jillr @s-hertel @tremble @willthames

click here for bot help


      		
    

  





        


            

            

              
            

        

      


      

            
  

    
  
    
    

  

  



    












      

  
            

    

      
    

    


      

          @ansibullbot
ansibullbot




            added
      

  module

  module

      

  plugins

  plugin (any type)

  labels


      Nov 22, 2022

    

  








      

  
      



  

  @tremble





  


    

      

  

    

        
    
    

  


      
          
  
      
            Copy link

  

      
    

  


  

      

  
    Contributor


      

  


  

    

      

      
            tremble
  

      

      

      commented


        Nov 22, 2022


      
  •

  

    
      

        
          edited
          
        
        
      

    
    
      
        
      Loading

      
    
  



    


  





      


        


  
    

      
          
@jrglynn2 thanks for taking the time to make this suggestion.


FYI the "latest" docs on docs.ansible.com are the version of the collection directly available as part of the latest released version of Ansible (the major version of the collection is effectively locked until the next version of Ansible is released), the "devel" docs on docs.ansible.com are the latest released version of the collection (as you'd find on galaxy.ansible.com), and will be available as part of Ansible when the next version of Ansible is released.


(Yeah, this is a little confusing, some of the implications of splitting out collections are still being ironed out).


As well as being renamed from "aws_kms" to "kms_key", the module was actually promoted to the amazon.aws collection.


The documentation for the latest released version of the kms_key/aws_key module can be found at:


https://docs.ansible.com/ansible/devel/collections/amazon/aws/kms_key_module.html


Alternatively we also have our absolute latest (unreleased) docs available on GitHub pages:

https://ansible-collections.github.io/amazon.aws/branch/main/collections/amazon/aws/index.html

      		
    

  





        


            

            

              
            

        

      


      

            
  

    
  
    
    

  

  



    












      

  
            


    


    

    

      
    

    


      

          @GomathiselviS
GomathiselviS




              self-assigned this


      Nov 28, 2022

    

  



  

  

    
  


  

      

    @GomathiselviS
GomathiselviS



    mentioned this issue
    
      Nov 29, 2022
    





  


  

      
   Merged

  







  




    

    


  


  
    
  
  

    
  softwarefactory-project-zuul bot

      pushed a commit
      that referenced
      this issue

    
      Dec 6, 2022
    
    

      


  

    

      


  

      
        @GomathiselviS
  





      

        
          kms_key: Add multi region support to create_key (#1290)
        

          
            
          

      


      

          

    
    
    

  

    


      


      

      


      
      

        
          a4ab720
        
      

    

  

    

      
kms_key: Add multi region support to create_key

Signed-off-by: GomathiselviS [email protected]
SUMMARY


Fixes #1281
ISSUE TYPE


Feature Pull Request

COMPONENT NAME

ADDITIONAL INFORMATION

Reviewed-by: Gonéri Le Bouder <[email protected]>
Reviewed-by: Jill R <None>
Reviewed-by: Mark Chappell <None>
Reviewed-by: Alina Buzachis <None>
Reviewed-by: GomathiselviS <None>

    




    

  




  


  
    
  
  

    
  alinabuzachis 

      pushed a commit
        to alinabuzachis/amazon.aws
      that referenced
      this issue

    
      Apr 27, 2023
    
    

      


  

    

      


  

      
        @GomathiselviS
      
        @alinabuzachis
  





      

        
          kms_key: Add multi region support to create_key (ansible-collections#…
        

          
            
          

      


      

          

    
    
    

  

      


      

      


      
      

        
          048672e
        
      

    

  

    

      
…1290)

kms_key: Add multi region support to create_key

Signed-off-by: GomathiselviS [email protected]
SUMMARY


Fixes ansible-collections#1281
ISSUE TYPE


Feature Pull Request

COMPONENT NAME

ADDITIONAL INFORMATION

Reviewed-by: Gonéri Le Bouder <[email protected]>
Reviewed-by: Jill R <None>
Reviewed-by: Mark Chappell <None>
Reviewed-by: Alina Buzachis <None>
Reviewed-by: GomathiselviS <None>

    




    

  




  

  

    
  


  

      

    @alinabuzachis
alinabuzachis



    mentioned this issue
    
      Apr 27, 2023
    





  


  

      
   Merged

  







  




  


  
    
  
  

    
  softwarefactory-project-zuul bot

      pushed a commit
      that referenced
      this issue

    
      Apr 28, 2023
    
    

      


  

    

      


  

      
        @alinabuzachis
  





      

        
          kms_key: Add multi region support to create_key (#1290) (#1489)
        

          
            
          

      


      

          

    
    
    

  

    


      


      

      


      
      

        
          2a45cd1
        
      

    

  

    

      
[manual backport stable-5] kms_key: Add multi region support to create_key (#1290)

kms_key: Add multi region support to create_key
Signed-off-by: GomathiselviS [email protected] SUMMARY
Fixes #1281
ISSUE TYPE
Feature Pull Request
COMPONENT NAME
ADDITIONAL INFORMATION
Reviewed-by: Gonéri Le Bouder [email protected]
Reviewed-by: Jill R 
Reviewed-by: Mark Chappell 
Reviewed-by: Alina Buzachis 
Reviewed-by: GomathiselviS 
SUMMARY


ISSUE TYPE


Bugfix Pull Request
Docs Pull Request
Feature Pull Request
New Module Pull Request

COMPONENT NAME

ADDITIONAL INFORMATION

    




    

  













  
  

    

      

  





  




  
  

              

  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment


  



  






  
                  




    

  


      
  

    Assignees
  



        

      

        

  
      @GomathiselviS
  
    GomathiselviS
    

      








      


  


  

    Labels
  



    

      

    feature

  This issue/PR relates to a feature request
  

    jira

  

    module

  module
  

    plugins

  plugin (any type)








      

  

    

        

    Projects
  


        




    None yet




  



      


  

    
  

    Milestone
  


      No milestone





    
      
          


  

    
      

        
    

    Development
  




          
  
Successfully merging a pull request may close this issue.





    


  
          
      kms_key: Add multi region support to create_key

    
      GomathiselviS/amazon.aws
    





    
  




      

    

  
      

  

    

      4 participants
    

    

        
          @tremble 
        
          @jrglynn2 
        
          @GomathiselviS 
        
          @ansibullbot