[PR #1199/5fe427c6 backport][stable-3] ec2_instance - validate options on tower_callback #1210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![patchback[bot]](https://avatars.githubusercontent.com/in/21488?s=60&v=4){kind=small}
ec2_instance - validate options on tower_callback Depends-On: #1202 SUMMARY Validate options for tower_callback parameter Set tower_callback.set_password (the password) to no_log=True ISSUE TYPE Bugfix Pull Request COMPONENT NAME ec2_instance ADDITIONAL INFORMATION Reviewed-by: Alina Buzachis <None> (cherry picked from commit 5fe427c)
Docs Build 📝Thank you for contribution!✨ This PR has been merged and your docs changes will be incorporated when they are next published. |
ansibullbot
added
bug
|
recheck |
|
recheck |
|
recheck |
|
recheck |
softwarefactory-project-zuul bot
pushed a commit
to ansible/ansible-zuul-jobs
that referenced
this pull request
Jan 4, 2023
…as released after stable-X was branched (#1734) Drop new sanity tests against old stable-X AWS branches Drop the latest sanity tests running against older stable-X branches. Sanity test fixes generally aren't fixing significant bugs/security issues. By running the latest sanity tests against old branches we make it harder to backport the real bug/security fixes. For example backporting ansible-collections/amazon.aws#1210 for stable-3 is currently blocked by a pile of documentation linting issues. Reviewed-by: Jill R <None>
tremble
approved these changes
Jan 4, 2023
|
regate |
|
regate |
softwarefactory-project-zuul
bot
deleted the
patchback/backports/stable-3/5fe427c6f4152489b2ed7f8ede86eb9b65940922/pr-1199
branch
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Sep 18, 2023
wafv2_rule_group - support for managing tags SUMMARY Add support for returning tags Add support for updating tags Add support for purge_tags Add fix for updating description when rules don't change. Ensure description of rule group is returned when updates happen Split integration tests from full wafv2 tests (full tests are broken) ISSUE TYPE Bugfix Pull Request Feature Pull Request COMPONENT NAME wafv2_rule_group wafv2_rule_group_info ADDITIONAL INFORMATION Reviewed-by: Joseph Torcasso <None> Reviewed-by: Mark Chappell <None>
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Sep 18, 2023
wafv2_rule_group - support for managing tags SUMMARY Add support for returning tags Add support for updating tags Add support for purge_tags Add fix for updating description when rules don't change. Ensure description of rule group is returned when updates happen Split integration tests from full wafv2 tests (full tests are broken) ISSUE TYPE Bugfix Pull Request Feature Pull Request COMPONENT NAME wafv2_rule_group wafv2_rule_group_info ADDITIONAL INFORMATION Reviewed-by: Joseph Torcasso <None> Reviewed-by: Mark Chappell <None>
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Oct 24, 2023
wafv2_rule_group - support for managing tags SUMMARY Add support for returning tags Add support for updating tags Add support for purge_tags Add fix for updating description when rules don't change. Ensure description of rule group is returned when updates happen Split integration tests from full wafv2 tests (full tests are broken) ISSUE TYPE Bugfix Pull Request Feature Pull Request COMPONENT NAME wafv2_rule_group wafv2_rule_group_info ADDITIONAL INFORMATION Reviewed-by: Joseph Torcasso <None> Reviewed-by: Mark Chappell <None>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of PR #1199 as merged into main (5fe427c).
Depends-On: #1202
Depends-On: ansible/ansible-zuul-jobs#1734
SUMMARY
tower_callback.set_password(the password) tono_log=TrueISSUE TYPE
COMPONENT NAME
ec2_instance
ADDITIONAL INFORMATION