-
Notifications
You must be signed in to change notification settings - Fork 341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[stable-5] Sanity test backports #1351
Merged
tremble
merged 3 commits into
ansible-collections:stable-5
from
tremble:backport/stable-5/sanity
Feb 5, 2023
Merged
[stable-5] Sanity test backports #1351
tremble
merged 3 commits into
ansible-collections:stable-5
from
tremble:backport/stable-5/sanity
Feb 5, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Various lint fixups SUMMARY Minor linting fixups ISSUE TYPE Feature Pull Request COMPONENT NAME ec2_instance ec2_vpc_nat_gateway lambda_layer s3_bucket plugins/module_utils/s3.py ADDITIONAL INFORMATION S3 unused imports aren't in changelog because they're related to unreleased refactoring. See Also: ansible-collections/news-for-maintainers#34 Reviewed-by: Felix Fontein <[email protected]>
Fix non-matching defaults in docs SUMMARY Fix various non-matching default values exposed by ansible/ansible#79267. ISSUE TYPE Docs Pull Request COMPONENT NAME various Reviewed-by: Alina Buzachis <None>
This comment was marked as resolved.
This comment was marked as resolved.
ansibullbot
added
community_review
feature
This issue/PR relates to a feature request
module
module
needs_triage
owner_pr
PR created by owner/maintainer
plugins
plugin (any type)
labels
Feb 4, 2023
recheck |
Docs Build 📝Thank you for contribution!✨ This PR has been merged and your docs changes will be incorporated when they are next published. |
felixfontein
reviewed
Feb 4, 2023
This comment was marked as outdated.
This comment was marked as outdated.
Co-authored-by: Felix Fontein <[email protected]>
felixfontein
approved these changes
Feb 5, 2023
recheck |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
community_review
feature
This issue/PR relates to a feature request
module
module
needs_triage
owner_pr
PR created by owner/maintainer
plugins
plugin (any type)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A combination of #1350 and #1226 manually backported
SUMMARY
False
defaults asNone
ansible/ansible#79267.(Fix non-matching defaults in docs #1226)ISSUE TYPE
COMPONENT NAME
various
ADDITIONAL INFORMATION