Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Black-en plugins/plugin_utils #1375

Merged
merged 2 commits into from
Feb 20, 2023
Merged

Black-en plugins/plugin_utils #1375

merged 2 commits into from
Feb 20, 2023

Conversation

tremble
Copy link
Contributor

@tremble tremble commented Feb 20, 2023

SUMMARY

Minor linting related changes to plugins/plugin_utils

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

plugins/plugin_utils

ADDITIONAL INFORMATION

This code hasn't been released yet.

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/2b176f1decb3432fac9e658228969df8

✔️ ansible-galaxy-importer SUCCESS in 4m 53s
✔️ build-ansible-collection SUCCESS in 12m 34s
✔️ ansible-test-sanity-aws-ansible-python38 SUCCESS in 11m 39s (non-voting)
✔️ ansible-test-sanity-aws-ansible-2.12-python38 SUCCESS in 11m 13s
✔️ ansible-test-sanity-aws-ansible-2.13-python38 SUCCESS in 11m 48s
✔️ ansible-test-sanity-aws-ansible-2.14 SUCCESS in 11m 40s
✔️ ansible-test-units-amazon-aws-python36 SUCCESS in 11m 12s
✔️ ansible-test-units-amazon-aws-python38 SUCCESS in 9m 25s
✔️ ansible-test-units-amazon-aws-python39 SUCCESS in 9m 22s
✔️ ansible-test-units-amazon-aws-python310 SUCCESS in 12m 18s
✔️ cloud-tox-py3 SUCCESS in 7m 56s
✔️ ansible-test-changelog SUCCESS in 4m 20s
✔️ ansible-test-splitter SUCCESS in 5m 08s
Skipped 44 jobs

@tremble tremble marked this pull request as ready for review February 20, 2023 14:41
@tremble tremble added the mergeit Merge the PR (SoftwareFactory) label Feb 20, 2023
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).
https://ansible.softwarefactory-project.io/zuul/buildset/7c4e1ec0fa61442fb9f20e8a411210a5

✔️ ansible-galaxy-importer SUCCESS in 4m 02s
✔️ build-ansible-collection SUCCESS in 15m 54s
✔️ ansible-test-splitter SUCCESS in 7m 14s
Skipped 44 jobs

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit c90a6b0 into ansible-collections:main Feb 20, 2023
@github-actions
Copy link

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and your docs changes will be incorporated when they are next published.

reparepo pushed a commit to reparepo/amazon.aws that referenced this pull request Mar 17, 2023
@tremble @goneri
iam_policy - add support for diff mode (ansible-collections#1375)
4ba58c0 
iam_policy - add support for diff mode

SUMMARY
fixes: ansible-collections#560

Adds support for diff mode
renames policies to policy_names so that in future we can return the policies (outside of the diff) too.
Attempts to handle AccessDenied more cleanly

ISSUE TYPE

Feature Pull Request

COMPONENT NAME
iam_policy
ADDITIONAL INFORMATION

Reviewed-by: Mark Chappell <None>
Reviewed-by: Markus Bergholz <[email protected]>

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@1ac84c3
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Sep 18, 2023
@tremble
iam_policy - add support for diff mode (ansible-collections#1375)
a726697 
iam_policy - add support for diff mode

SUMMARY
fixes: ansible-collections#560

Adds support for diff mode
renames policies to policy_names so that in future we can return the policies (outside of the diff) too.
Attempts to handle AccessDenied more cleanly

ISSUE TYPE

Feature Pull Request

COMPONENT NAME
iam_policy
ADDITIONAL INFORMATION

Reviewed-by: Mark Chappell <None>
Reviewed-by: Markus Bergholz <[email protected]>
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Sep 18, 2023
@tremble @abikouo
iam_policy - add support for diff mode (ansible-collections#1375)
263e2d4 
iam_policy - add support for diff mode

SUMMARY
fixes: ansible-collections#560

Adds support for diff mode
renames policies to policy_names so that in future we can return the policies (outside of the diff) too.
Attempts to handle AccessDenied more cleanly

ISSUE TYPE

Feature Pull Request

COMPONENT NAME
iam_policy
ADDITIONAL INFORMATION

Reviewed-by: Mark Chappell <None>
Reviewed-by: Markus Bergholz <[email protected]>
@tremble tremble deleted the darker/plugin_utils branch September 27, 2023 06:59
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Oct 24, 2023
@tremble
iam_policy - add support for diff mode (ansible-collections#1375)
1ac84c3 
iam_policy - add support for diff mode

SUMMARY
fixes: ansible-collections#560

Adds support for diff mode
renames policies to policy_names so that in future we can return the policies (outside of the diff) too.
Attempts to handle AccessDenied more cleanly

ISSUE TYPE

Feature Pull Request

COMPONENT NAME
iam_policy
ADDITIONAL INFORMATION

Reviewed-by: Mark Chappell <None>
Reviewed-by: Markus Bergholz <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alinabuzachis alinabuzachis alinabuzachis approved these changes

@jillr jillr jillr approved these changes

Assignees
No one assigned
Labels
mergeit Merge the PR (SoftwareFactory)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tremble @jillr @alinabuzachis