Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR #1395/15d92a74 backport][stable-5] Disable S3 tests related to removing bucket encryption #1398

Conversation

patchback[bot]
Copy link

@patchback patchback bot commented Mar 1, 2023

This is a backport of PR #1395 as merged into main (15d92a7).

SUMMARY

Amazon now enables S3-SSE bucket encryption by default and it's not possible to disable it. Disable the relevant tests but leave a minimal framework in place.

ISSUE TYPE
  • Tests Pull Request
COMPONENT NAME

s3_bucket

ADDITIONAL INFORMATION

Disable S3 tests related to removing bucket encryption

SUMMARY
Amazon now enables S3-SSE bucket encryption by default and it's not possible to disable it.  Disable the relevant tests but leave a minimal framework in place.
ISSUE TYPE

Tests Pull Request

COMPONENT NAME
s3_bucket
ADDITIONAL INFORMATION

Reviewed-by: Alina Buzachis
(cherry picked from commit 15d92a7)
@github-actions
Copy link

github-actions bot commented Mar 1, 2023

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and your docs changes will be incorporated when they are next published.

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/0ea04c855a284eadb46fd408f23abfa9

✔️ ansible-galaxy-importer SUCCESS in 4m 03s
✔️ build-ansible-collection SUCCESS in 13m 11s
✔️ ansible-test-sanity-aws-ansible-python38 SUCCESS in 8m 50s (non-voting)
✔️ ansible-test-sanity-aws-ansible-2.12-python38 SUCCESS in 13m 01s
✔️ ansible-test-sanity-aws-ansible-2.13-python38 SUCCESS in 9m 02s
✔️ ansible-test-sanity-aws-ansible-2.14 SUCCESS in 10m 01s
✔️ ansible-test-units-amazon-aws-python36 SUCCESS in 9m 20s
✔️ ansible-test-units-amazon-aws-python38 SUCCESS in 5m 52s
✔️ ansible-test-units-amazon-aws-python39 SUCCESS in 8m 15s
✔️ ansible-test-units-amazon-aws-python310 SUCCESS in 6m 03s
✔️ cloud-tox-py3 SUCCESS in 5m 05s
✔️ ansible-test-changelog SUCCESS in 4m 44s
✔️ ansible-test-splitter SUCCESS in 5m 14s
✔️ integration-amazon.aws-1 SUCCESS in 9m 23s
✔️ integration-community.aws-1 SUCCESS in 20m 26s
Skipped 42 jobs

@tremble tremble added the mergeit Merge the PR (SoftwareFactory) label Mar 3, 2023
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).
https://ansible.softwarefactory-project.io/zuul/buildset/a60455d03d5342d29ba840d38c9c6cb6

✔️ ansible-galaxy-importer SUCCESS in 5m 13s
✔️ build-ansible-collection SUCCESS in 12m 24s
✔️ ansible-test-splitter SUCCESS in 4m 47s
✔️ integration-amazon.aws-1 SUCCESS in 6m 02s
✔️ integration-community.aws-1 SUCCESS in 18m 13s
Skipped 42 jobs

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit e274f54 into stable-5 Mar 3, 2023
@softwarefactory-project-zuul softwarefactory-project-zuul bot deleted the patchback/backports/stable-5/15d92a74d777ca23596e3cbcbaa59e97f20b9541/pr-1395 branch March 3, 2023 15:11
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Sep 18, 2023
…1398)

s3-lifecycle: fix remove rule with empty prefix

SUMMARY
In case of removing a lifecycle policy without a prefix, there will be no prefix key in the existing_rule filter
Signed-off-by: Seena Fallah [email protected]
ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME
s3_lifecycle

Reviewed-by: Mark Chappell <None>
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Sep 18, 2023
…1398)

s3-lifecycle: fix remove rule with empty prefix

SUMMARY
In case of removing a lifecycle policy without a prefix, there will be no prefix key in the existing_rule filter
Signed-off-by: Seena Fallah [email protected]
ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME
s3_lifecycle

Reviewed-by: Mark Chappell <None>
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Oct 24, 2023
…1398)

s3-lifecycle: fix remove rule with empty prefix

SUMMARY
In case of removing a lifecycle policy without a prefix, there will be no prefix key in the existing_rule filter
Signed-off-by: Seena Fallah [email protected]
ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME
s3_lifecycle

Reviewed-by: Mark Chappell <None>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mergeit Merge the PR (SoftwareFactory)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant