Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bulk migration to Python 3.6 f-strings (1) #1483

Merged

Conversation

tremble
Copy link
Contributor

@tremble tremble commented Apr 27, 2023

SUMMARY

We've dropped support for Python < 3.6, be more consistent with out code formatting and move to fstrings.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

plugins/
tests/unit/

ADDITIONAL INFORMATION

deliberately skips

@tremble tremble force-pushed the fstring/bulk branch 3 times, most recently from 7dcdb60 to ca689b8 Compare April 27, 2023 11:14
@softwarefactory-project-zuul
Copy link
Contributor

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/9eeffe96ddbe470aa6ac070987157267

✔️ ansible-galaxy-importer SUCCESS in 4m 36s
✔️ build-ansible-collection SUCCESS in 12m 55s
✔️ ansible-test-splitter SUCCESS in 4m 53s
✔️ integration-amazon.aws-1 SUCCESS in 15m 17s
✔️ integration-amazon.aws-2 SUCCESS in 33m 45s
✔️ integration-amazon.aws-3 SUCCESS in 17m 31s
✔️ integration-amazon.aws-4 SUCCESS in 25m 08s
✔️ integration-amazon.aws-5 SUCCESS in 22m 36s
✔️ integration-amazon.aws-6 SUCCESS in 15m 33s
✔️ integration-amazon.aws-7 SUCCESS in 21m 54s
✔️ integration-amazon.aws-8 SUCCESS in 14m 20s
✔️ integration-amazon.aws-9 SUCCESS in 21m 05s
✔️ integration-amazon.aws-10 SUCCESS in 9m 32s
✔️ integration-amazon.aws-11 SUCCESS in 26m 20s
✔️ integration-amazon.aws-12 SUCCESS in 18m 52s
✔️ integration-amazon.aws-13 SUCCESS in 20m 01s
✔️ integration-amazon.aws-14 SUCCESS in 20m 10s
✔️ integration-amazon.aws-15 SUCCESS in 20m 46s
integration-amazon.aws-16 FAILURE in 22m 48s
✔️ integration-amazon.aws-17 SUCCESS in 25m 50s
integration-amazon.aws-18 FAILURE in 12m 26s
integration-amazon.aws-19 FAILURE in 19m 14s
✔️ integration-amazon.aws-20 SUCCESS in 7m 36s
✔️ integration-community.aws-1 SUCCESS in 30m 31s
✔️ integration-community.aws-2 SUCCESS in 22m 01s
✔️ integration-community.aws-3 SUCCESS in 5m 43s
✔️ integration-community.aws-4 SUCCESS in 35m 14s
✔️ integration-community.aws-5 SUCCESS in 37m 33s
✔️ integration-community.aws-6 SUCCESS in 6m 00s
✔️ integration-community.aws-7 SUCCESS in 25m 24s
✔️ integration-community.aws-8 SUCCESS in 19m 47s
✔️ integration-community.aws-9 SUCCESS in 31m 45s
✔️ integration-community.aws-10 SUCCESS in 22m 58s
✔️ integration-community.aws-11 SUCCESS in 30m 11s
✔️ integration-community.aws-12 SUCCESS in 31m 37s
✔️ integration-community.aws-13 SUCCESS in 21m 27s
✔️ integration-community.aws-14 SUCCESS in 41m 55s
✔️ integration-community.aws-15 SUCCESS in 15m 42s
✔️ integration-community.aws-16 SUCCESS in 41m 25s
✔️ integration-community.aws-17 SUCCESS in 8m 38s
✔️ integration-community.aws-18 SUCCESS in 15m 49s
✔️ integration-community.aws-19 SUCCESS in 19m 58s
✔️ integration-community.aws-20 SUCCESS in 10m 13s
Skipped 4 jobs

@tremble
Copy link
Contributor Author

tremble commented May 3, 2023

recheck

@softwarefactory-project-zuul
Copy link
Contributor

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/90be882cbfc2481e9536871a0eff1351

✔️ ansible-galaxy-importer SUCCESS in 3m 49s
✔️ build-ansible-collection SUCCESS in 13m 23s
✔️ ansible-test-splitter SUCCESS in 5m 10s
✔️ integration-amazon.aws-1 SUCCESS in 12m 15s
✔️ integration-amazon.aws-2 SUCCESS in 28m 34s
✔️ integration-amazon.aws-3 SUCCESS in 17m 07s
✔️ integration-amazon.aws-4 SUCCESS in 26m 07s
✔️ integration-amazon.aws-5 SUCCESS in 26m 04s
✔️ integration-amazon.aws-6 SUCCESS in 21m 51s
✔️ integration-amazon.aws-7 SUCCESS in 22m 25s
✔️ integration-amazon.aws-8 SUCCESS in 14m 02s
✔️ integration-amazon.aws-9 SUCCESS in 12m 08s
✔️ integration-amazon.aws-10 SUCCESS in 14m 36s
✔️ integration-amazon.aws-11 SUCCESS in 27m 49s
✔️ integration-amazon.aws-12 SUCCESS in 14m 46s
✔️ integration-amazon.aws-13 SUCCESS in 13m 14s
✔️ integration-amazon.aws-14 SUCCESS in 15m 41s
✔️ integration-amazon.aws-15 SUCCESS in 16m 39s
integration-amazon.aws-16 FAILURE in 20m 38s
✔️ integration-amazon.aws-17 SUCCESS in 27m 01s
✔️ integration-amazon.aws-18 SUCCESS in 12m 22s
integration-amazon.aws-19 FAILURE in 16m 10s
✔️ integration-amazon.aws-20 SUCCESS in 5m 51s
Skipped 24 jobs

tremble added 3 commits May 4, 2023 10:14
We've dropped support for Python <3.6, bulk migrate to fstrings and perform some general string cleanup

A combination of
* `black --preview`
* `flynt`
* some manual cleanup
@tremble tremble marked this pull request as ready for review May 4, 2023 09:39
@softwarefactory-project-zuul
Copy link
Contributor

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/01862fab0d5d4e5fb29fe8d8cb8fcde9

✔️ ansible-galaxy-importer SUCCESS in 4m 02s
✔️ build-ansible-collection SUCCESS in 13m 25s
✔️ ansible-test-splitter SUCCESS in 5m 51s
✔️ integration-amazon.aws-1 SUCCESS in 19m 14s
✔️ integration-amazon.aws-2 SUCCESS in 31m 26s
✔️ integration-amazon.aws-3 SUCCESS in 20m 04s
✔️ integration-amazon.aws-4 SUCCESS in 27m 57s
✔️ integration-amazon.aws-5 SUCCESS in 31m 37s
✔️ integration-amazon.aws-6 SUCCESS in 17m 41s
✔️ integration-amazon.aws-7 SUCCESS in 24m 48s
✔️ integration-amazon.aws-8 SUCCESS in 11m 54s
✔️ integration-amazon.aws-9 SUCCESS in 27m 39s
✔️ integration-amazon.aws-10 SUCCESS in 18m 33s
✔️ integration-amazon.aws-11 SUCCESS in 29m 13s
✔️ integration-amazon.aws-12 SUCCESS in 17m 02s
✔️ integration-amazon.aws-13 SUCCESS in 16m 46s
✔️ integration-amazon.aws-14 SUCCESS in 20m 26s
✔️ integration-amazon.aws-15 SUCCESS in 24m 43s
✔️ integration-amazon.aws-16 SUCCESS in 14m 35s
✔️ integration-amazon.aws-17 SUCCESS in 29m 52s
✔️ integration-amazon.aws-18 SUCCESS in 12m 30s
integration-amazon.aws-19 FAILURE in 17m 09s
✔️ integration-amazon.aws-20 SUCCESS in 5m 53s
✔️ integration-community.aws-1 SUCCESS in 8m 48s
✔️ integration-community.aws-2 SUCCESS in 9m 42s
✔️ integration-community.aws-3 SUCCESS in 13m 27s
Skipped 21 jobs

@tremble tremble added the mergeit Merge the PR (SoftwareFactory) label May 4, 2023
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).
https://ansible.softwarefactory-project.io/zuul/buildset/eff208c6b6c446bdac229cc57d3f87b2

✔️ ansible-galaxy-importer SUCCESS in 5m 27s
✔️ build-ansible-collection SUCCESS in 13m 07s
✔️ ansible-test-splitter SUCCESS in 7m 27s
✔️ integration-amazon.aws-1 SUCCESS in 14m 10s
✔️ integration-amazon.aws-2 SUCCESS in 49m 45s
✔️ integration-amazon.aws-3 SUCCESS in 16m 33s
✔️ integration-amazon.aws-4 SUCCESS in 27m 57s
✔️ integration-amazon.aws-5 SUCCESS in 23m 26s
✔️ integration-amazon.aws-6 SUCCESS in 22m 03s
✔️ integration-amazon.aws-7 SUCCESS in 19m 39s
✔️ integration-amazon.aws-8 SUCCESS in 11m 06s
✔️ integration-amazon.aws-9 SUCCESS in 19m 35s
✔️ integration-amazon.aws-10 SUCCESS in 9m 22s
✔️ integration-amazon.aws-11 SUCCESS in 31m 54s
✔️ integration-amazon.aws-12 SUCCESS in 16m 36s
✔️ integration-amazon.aws-13 SUCCESS in 16m 44s
✔️ integration-amazon.aws-14 SUCCESS in 14m 48s
✔️ integration-amazon.aws-15 SUCCESS in 14m 07s
✔️ integration-amazon.aws-16 SUCCESS in 26m 34s
✔️ integration-amazon.aws-17 SUCCESS in 25m 44s
✔️ integration-amazon.aws-18 SUCCESS in 12m 27s
✔️ integration-amazon.aws-19 SUCCESS in 18m 06s
✔️ integration-amazon.aws-20 SUCCESS in 5m 57s
Skipped 24 jobs

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit c682bd1 into ansible-collections:main May 4, 2023
@github-actions
Copy link

github-actions bot commented May 4, 2023

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and your docs changes will be incorporated when they are next published.

abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Sep 18, 2023
…ns#1483)

* Remove modules
* Update runtime
* Add changelog fragment
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Sep 18, 2023
…ns#1483)

* Remove modules
* Update runtime
* Add changelog fragment
@tremble tremble deleted the fstring/bulk branch September 27, 2023 07:00
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Oct 24, 2023
…ns#1483)

* Remove modules
* Update runtime
* Add changelog fragment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mergeit Merge the PR (SoftwareFactory)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants