Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backport] [stable-5] Flag RSA example in unit test to be ignored by GitLeaks (#1518) #1521

Conversation

tremble
Copy link
Contributor

@tremble tremble commented May 5, 2023

Manual backport of #1518

SUMMARY

The example in the unit test keeps triggering GitLeaks, flag to be ignored by GitLeaks (it's a fake)

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

ec2_key

ADDITIONAL INFORMATION

Reviewed-by: Jill R
Reviewed-by: Alina Buzachis

…ansible-collections#1518)

Flag RSA example in unit test to be ignored by GitLeaks

SUMMARY
The example in the unit test keeps triggering GitLeaks, flag to be ignored by GitLeaks (it's a fake)
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
ec2_key
ADDITIONAL INFORMATION

Reviewed-by: Jill R
Reviewed-by: Alina Buzachis
@tremble tremble marked this pull request as ready for review May 5, 2023 07:20
@tremble tremble requested a review from alinabuzachis May 5, 2023 07:20
@softwarefactory-project-zuul
Copy link
Contributor

@alinabuzachis alinabuzachis added the mergeit Merge the PR (SoftwareFactory) label May 5, 2023
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).
https://ansible.softwarefactory-project.io/zuul/buildset/46bd0fa2a6df404da6ec600856bcd79a

✔️ ansible-galaxy-importer SUCCESS in 3m 59s
✔️ build-ansible-collection SUCCESS in 12m 50s

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 76518a3 into ansible-collections:stable-5 May 5, 2023
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mergeit Merge the PR (SoftwareFactory)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants