[PR #1701/19b89f68 backport][stable-6] Backup selection bugfix #1710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![patchback[bot]](https://avatars.githubusercontent.com/in/21488?s=60&v=4){kind=small}
ansibullbot
added
bug
|
Build failed. ✔️ ansible-galaxy-importer SUCCESS in 4m 19s |
hakbailey
force-pushed
the
patchback/backports/stable-6/19b89f682227f8755322250c929355812dc37a2c/pr-1701
branch
from
919d0ff to
81e99a3
Compare
|
Rebased onto current stable-6. |
|
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 5m 00s |
Backup selection bugfix SUMMARY Fix bug in backup_selection where an existing backup selection was not updated to add Conditions if that value was previously empty. ISSUE TYPE Bugfix Pull Request COMPONENT NAME backup_selection ADDITIONAL INFORMATION Split into two commits, the first commit adds comprehensive integration tests to cover the scenarios that were failing and the second commit fixes the code. Reviewed-by: Mike Graves <[email protected]> Reviewed-by: Alina Buzachis (cherry picked from commit 19b89f6)
hakbailey
force-pushed
the
patchback/backports/stable-6/19b89f682227f8755322250c929355812dc37a2c/pr-1701
branch
from
81e99a3 to
b5a008a
Compare
alinabuzachis
approved these changes
Sep 1, 2023
|
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 4m 05s |
hakbailey
deleted the
patchback/backports/stable-6/19b89f682227f8755322250c929355812dc37a2c/pr-1701
branch
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Sep 18, 2023
iam_access_key - fix example docs SUMMARY Closes ansible-collections#1710 ISSUE TYPE Docs Pull Request COMPONENT NAME iam_access_key Reviewed-by: Mark Chappell <None>
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Sep 18, 2023
iam_access_key - fix example docs SUMMARY Closes ansible-collections#1710 ISSUE TYPE Docs Pull Request COMPONENT NAME iam_access_key Reviewed-by: Mark Chappell <None>
alinabuzachis
pushed a commit
to alinabuzachis/amazon.aws
that referenced
this pull request
Sep 27, 2023
iam_access_key - fix example docs SUMMARY Closes ansible-collections#1710 ISSUE TYPE Docs Pull Request COMPONENT NAME iam_access_key Reviewed-by: Mark Chappell <None> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@88872b3
alinabuzachis
pushed a commit
to alinabuzachis/amazon.aws
that referenced
this pull request
Sep 27, 2023
iam_access_key - fix example docs SUMMARY Closes ansible-collections#1710 ISSUE TYPE Docs Pull Request COMPONENT NAME iam_access_key Reviewed-by: Mark Chappell <None> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@88872b3
alinabuzachis
pushed a commit
to alinabuzachis/amazon.aws
that referenced
this pull request
Sep 27, 2023
iam_access_key - fix example docs SUMMARY Closes ansible-collections#1710 ISSUE TYPE Docs Pull Request COMPONENT NAME iam_access_key Reviewed-by: Mark Chappell <None> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@88872b3
alinabuzachis
pushed a commit
to alinabuzachis/amazon.aws
that referenced
this pull request
Oct 6, 2023
iam_access_key - fix example docs SUMMARY Closes ansible-collections#1710 ISSUE TYPE Docs Pull Request COMPONENT NAME iam_access_key Reviewed-by: Mark Chappell <None> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@88872b3
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Oct 24, 2023
iam_access_key - fix example docs SUMMARY Closes ansible-collections#1710 ISSUE TYPE Docs Pull Request COMPONENT NAME iam_access_key Reviewed-by: Mark Chappell <None>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of PR #1701 as merged into main (19b89f6).
SUMMARY
Fix bug in backup_selection where an existing backup selection was not updated to add Conditions if that value was previously empty.
ISSUE TYPE
COMPONENT NAME
backup_selection
ADDITIONAL INFORMATION
Split into two commits, the first commit adds comprehensive integration tests to cover the scenarios that were failing and the second commit fixes the code.