Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backport][stable-6] Mass update of docs and tests (credentials/session tokens) #1732

Merged

Conversation

tremble
Copy link
Contributor

@tremble tremble commented Sep 4, 2023

SUMMARY

Manual backport of #1714 and #1721

We had a cleanup of credentials/session parameters which included a batch of deprecations and renames.
Ensure that all of our tests and docs are using the 'canonical' names

ISSUE TYPE
  • Docs Pull Request
COMPONENT NAME

plugins/inventory/aws_ec2.py
plugins/lookup/secretsmanager_secret.py
plugins/lookup/ssm_parameter.py
plugins/modules/ec2_security_group.py
tests/integration

ADDITIONAL INFORMATION

@tremble
Copy link
Contributor Author

tremble commented Sep 4, 2023

@alinabuzachis IMHO this can wait for #1725

@github-actions
Copy link

github-actions bot commented Sep 4, 2023

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and your docs changes will be incorporated when they are next published.

@softwarefactory-project-zuul
Copy link
Contributor

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/6d2cc5050d454922b17346c59088f753

✔️ ansible-galaxy-importer SUCCESS in 5m 13s
✔️ build-ansible-collection SUCCESS in 13m 27s
✔️ ansible-test-splitter SUCCESS in 5m 39s
✔️ integration-amazon.aws-1 SUCCESS in 26m 55s
✔️ integration-amazon.aws-2 SUCCESS in 41m 10s
✔️ integration-amazon.aws-3 SUCCESS in 22m 13s
✔️ integration-amazon.aws-4 SUCCESS in 33m 06s
✔️ integration-amazon.aws-5 SUCCESS in 30m 27s
✔️ integration-amazon.aws-6 SUCCESS in 49m 03s
✔️ integration-amazon.aws-7 SUCCESS in 18m 59s
✔️ integration-amazon.aws-8 SUCCESS in 43m 24s
integration-amazon.aws-9 RETRY_LIMIT in 6m 53s
integration-amazon.aws-10 RETRY_LIMIT in 7m 48s
✔️ integration-amazon.aws-11 SUCCESS in 33m 42s
✔️ integration-amazon.aws-12 SUCCESS in 14m 34s
✔️ integration-amazon.aws-13 SUCCESS in 23m 47s
✔️ integration-amazon.aws-14 SUCCESS in 28m 36s
✔️ integration-amazon.aws-15 SUCCESS in 42m 38s
✔️ integration-amazon.aws-16 SUCCESS in 40m 05s
✔️ integration-amazon.aws-17 SUCCESS in 44m 32s
✔️ integration-amazon.aws-18 SUCCESS in 36m 48s
✔️ integration-amazon.aws-19 SUCCESS in 49m 09s
✔️ integration-amazon.aws-20 SUCCESS in 24m 39s
✔️ integration-amazon.aws-21 SUCCESS in 29m 21s
✔️ integration-amazon.aws-22 SUCCESS in 20m 41s
Skipped 22 jobs

@tremble tremble marked this pull request as ready for review September 7, 2023 11:42
@tremble tremble added the mergeit Merge the PR (SoftwareFactory) label Sep 11, 2023
@softwarefactory-project-zuul
Copy link
Contributor

Merge Failed.

This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.

@tremble tremble force-pushed the backport/stable-6/1714-and-1721 branch from bf77fa0 to 3f92ca8 Compare September 11, 2023 13:58
@softwarefactory-project-zuul
Copy link
Contributor

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/a9ef5aceec9249a4afa12e0f8cb8ac29

✔️ ansible-galaxy-importer SUCCESS in 5m 22s
✔️ build-ansible-collection SUCCESS in 13m 15s
✔️ ansible-test-splitter SUCCESS in 4m 50s
✔️ integration-amazon.aws-1 SUCCESS in 25m 41s
✔️ integration-amazon.aws-2 SUCCESS in 31m 56s
✔️ integration-amazon.aws-3 SUCCESS in 23m 22s
✔️ integration-amazon.aws-4 SUCCESS in 36m 12s
✔️ integration-amazon.aws-5 SUCCESS in 29m 46s
✔️ integration-amazon.aws-6 SUCCESS in 47m 53s
✔️ integration-amazon.aws-7 SUCCESS in 16m 15s
✔️ integration-amazon.aws-8 SUCCESS in 41m 31s
✔️ integration-amazon.aws-9 SUCCESS in 44m 02s
✔️ integration-amazon.aws-10 SUCCESS in 41m 24s
✔️ integration-amazon.aws-11 SUCCESS in 41m 55s
✔️ integration-amazon.aws-12 SUCCESS in 15m 08s
integration-amazon.aws-13 FAILURE in 24m 14s
✔️ integration-amazon.aws-14 SUCCESS in 29m 16s
✔️ integration-amazon.aws-15 SUCCESS in 43m 11s
✔️ integration-amazon.aws-16 SUCCESS in 36m 16s
✔️ integration-amazon.aws-17 SUCCESS in 41m 41s
✔️ integration-amazon.aws-18 SUCCESS in 33m 43s
✔️ integration-amazon.aws-19 SUCCESS in 41m 27s
✔️ integration-amazon.aws-20 SUCCESS in 23m 58s
✔️ integration-amazon.aws-21 SUCCESS in 36m 22s
✔️ integration-amazon.aws-22 SUCCESS in 22m 02s
✔️ integration-community.aws-1 SUCCESS in 17m 15s
Skipped 21 jobs

@tremble
Copy link
Contributor Author

tremble commented Sep 11, 2023

recheck

@softwarefactory-project-zuul
Copy link
Contributor

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/ebaba8db31374ea19fee8615fbfc4a80

✔️ ansible-galaxy-importer SUCCESS in 7m 19s
✔️ build-ansible-collection SUCCESS in 12m 52s
✔️ ansible-test-splitter SUCCESS in 5m 05s
✔️ integration-amazon.aws-1 SUCCESS in 27m 03s
✔️ integration-amazon.aws-2 SUCCESS in 33m 30s
✔️ integration-amazon.aws-3 SUCCESS in 23m 50s
✔️ integration-amazon.aws-4 SUCCESS in 37m 21s
✔️ integration-amazon.aws-5 SUCCESS in 26m 10s
✔️ integration-amazon.aws-6 SUCCESS in 45m 46s
✔️ integration-amazon.aws-7 SUCCESS in 19m 49s
✔️ integration-amazon.aws-8 SUCCESS in 35m 59s
✔️ integration-amazon.aws-9 SUCCESS in 43m 28s
✔️ integration-amazon.aws-10 SUCCESS in 37m 44s
✔️ integration-amazon.aws-11 SUCCESS in 35m 32s
✔️ integration-amazon.aws-12 SUCCESS in 11m 39s
integration-amazon.aws-13 FAILURE in 23m 39s
✔️ integration-amazon.aws-14 SUCCESS in 34m 24s
✔️ integration-amazon.aws-15 SUCCESS in 42m 43s
✔️ integration-amazon.aws-16 SUCCESS in 39m 55s
✔️ integration-amazon.aws-17 SUCCESS in 45m 24s
integration-amazon.aws-18 RETRY_LIMIT in 1m 42s
✔️ integration-amazon.aws-19 SUCCESS in 39m 05s
✔️ integration-amazon.aws-20 SUCCESS in 35m 05s
✔️ integration-amazon.aws-21 SUCCESS in 36m 47s
✔️ integration-amazon.aws-22 SUCCESS in 20m 07s
Skipped 22 jobs

@tremble
Copy link
Contributor Author

tremble commented Sep 12, 2023

recheck

@softwarefactory-project-zuul
Copy link
Contributor

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/a6f1443f257d4603b1976599e0a23853

✔️ ansible-galaxy-importer SUCCESS in 5m 22s
✔️ build-ansible-collection SUCCESS in 12m 25s
✔️ ansible-test-splitter SUCCESS in 5m 06s
✔️ integration-amazon.aws-1 SUCCESS in 24m 47s
✔️ integration-amazon.aws-2 SUCCESS in 31m 46s
✔️ integration-amazon.aws-3 SUCCESS in 21m 26s
✔️ integration-amazon.aws-4 SUCCESS in 29m 55s
✔️ integration-amazon.aws-5 SUCCESS in 30m 11s
✔️ integration-amazon.aws-6 SUCCESS in 46m 40s
✔️ integration-amazon.aws-7 SUCCESS in 17m 33s
✔️ integration-amazon.aws-8 SUCCESS in 42m 16s
✔️ integration-amazon.aws-9 SUCCESS in 42m 05s
✔️ integration-amazon.aws-10 SUCCESS in 42m 40s
✔️ integration-amazon.aws-11 SUCCESS in 43m 12s
✔️ integration-amazon.aws-12 SUCCESS in 15m 41s
integration-amazon.aws-13 FAILURE in 25m 38s
✔️ integration-amazon.aws-14 SUCCESS in 31m 42s
integration-amazon.aws-15 RETRY_LIMIT in 1m 45s
✔️ integration-amazon.aws-16 SUCCESS in 41m 34s
✔️ integration-amazon.aws-17 SUCCESS in 40m 34s
integration-amazon.aws-18 FAILURE in 38m 46s
✔️ integration-amazon.aws-19 SUCCESS in 48m 43s
✔️ integration-amazon.aws-20 SUCCESS in 28m 54s
✔️ integration-amazon.aws-21 SUCCESS in 34m 58s
✔️ integration-amazon.aws-22 SUCCESS in 22m 12s
Skipped 22 jobs

@tremble
Copy link
Contributor Author

tremble commented Sep 13, 2023

recheck

@softwarefactory-project-zuul
Copy link
Contributor

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/f2a2fff5c16c452c96bd565affd5d49a

✔️ ansible-galaxy-importer SUCCESS in 5m 06s
✔️ build-ansible-collection SUCCESS in 13m 23s
✔️ ansible-test-splitter SUCCESS in 6m 09s
✔️ integration-amazon.aws-1 SUCCESS in 28m 19s
✔️ integration-amazon.aws-2 SUCCESS in 41m 37s
✔️ integration-amazon.aws-3 SUCCESS in 21m 14s
✔️ integration-amazon.aws-4 SUCCESS in 34m 47s
✔️ integration-amazon.aws-5 SUCCESS in 28m 28s
✔️ integration-amazon.aws-6 SUCCESS in 52m 31s
✔️ integration-amazon.aws-7 SUCCESS in 16m 36s
✔️ integration-amazon.aws-8 SUCCESS in 40m 09s
✔️ integration-amazon.aws-9 SUCCESS in 44m 39s
✔️ integration-amazon.aws-10 SUCCESS in 39m 56s
✔️ integration-amazon.aws-11 SUCCESS in 33m 54s
✔️ integration-amazon.aws-12 SUCCESS in 15m 42s
integration-amazon.aws-13 FAILURE in 24m 44s
✔️ integration-amazon.aws-14 SUCCESS in 27m 05s
✔️ integration-amazon.aws-15 SUCCESS in 43m 07s
✔️ integration-amazon.aws-16 SUCCESS in 42m 17s
✔️ integration-amazon.aws-17 SUCCESS in 43m 35s
✔️ integration-amazon.aws-18 SUCCESS in 42m 13s
✔️ integration-amazon.aws-19 SUCCESS in 39m 53s
✔️ integration-amazon.aws-20 SUCCESS in 37m 33s
✔️ integration-amazon.aws-21 SUCCESS in 38m 00s
✔️ integration-amazon.aws-22 SUCCESS in 20m 35s
Skipped 22 jobs

@tremble
Copy link
Contributor Author

tremble commented Sep 15, 2023

recheck

@softwarefactory-project-zuul
Copy link
Contributor

Build failed (gate pipeline). For information on how to proceed, see
http://docs.openstack.org/infra/manual/developers.html#automated-testing

https://ansible.softwarefactory-project.io/zuul/buildset/666ff179ad3a4673bbf58da1f36f02e6

✔️ ansible-galaxy-importer SUCCESS in 8m 42s
✔️ build-ansible-collection SUCCESS in 12m 33s
✔️ ansible-test-splitter SUCCESS in 4m 45s
✔️ integration-amazon.aws-1 SUCCESS in 26m 00s
✔️ integration-amazon.aws-2 SUCCESS in 34m 29s
✔️ integration-amazon.aws-3 SUCCESS in 18m 43s
✔️ integration-amazon.aws-4 SUCCESS in 37m 05s
✔️ integration-amazon.aws-5 SUCCESS in 35m 41s
✔️ integration-amazon.aws-6 SUCCESS in 45m 58s
✔️ integration-amazon.aws-7 SUCCESS in 20m 39s
integration-amazon.aws-8 RETRY_LIMIT in 1m 44s
integration-amazon.aws-9 RETRY_LIMIT in 1m 44s
✔️ integration-amazon.aws-10 SUCCESS in 37m 06s
✔️ integration-amazon.aws-11 SUCCESS in 35m 19s
✔️ integration-amazon.aws-12 SUCCESS in 12m 00s
integration-amazon.aws-13 FAILURE in 21m 17s
✔️ integration-amazon.aws-14 SUCCESS in 28m 21s
integration-amazon.aws-15 RETRY_LIMIT in 1m 42s
✔️ integration-amazon.aws-16 SUCCESS in 41m 35s
✔️ integration-amazon.aws-17 SUCCESS in 42m 16s
✔️ integration-amazon.aws-18 SUCCESS in 44m 59s
✔️ integration-amazon.aws-19 SUCCESS in 41m 37s
✔️ integration-amazon.aws-20 SUCCESS in 25m 49s
✔️ integration-amazon.aws-21 SUCCESS in 37m 39s
✔️ integration-amazon.aws-22 SUCCESS in 21m 43s
Skipped 22 jobs

@softwarefactory-project-zuul
Copy link
Contributor

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/d93ae47391184b939abbe63da66b3cef

✔️ ansible-galaxy-importer SUCCESS in 5m 15s
✔️ build-ansible-collection SUCCESS in 12m 34s
✔️ ansible-test-splitter SUCCESS in 4m 46s
✔️ integration-amazon.aws-1 SUCCESS in 25m 24s
✔️ integration-amazon.aws-2 SUCCESS in 32m 53s
✔️ integration-amazon.aws-3 SUCCESS in 22m 57s
✔️ integration-amazon.aws-4 SUCCESS in 28m 43s
✔️ integration-amazon.aws-5 SUCCESS in 24m 56s
✔️ integration-amazon.aws-6 SUCCESS in 46m 27s
✔️ integration-amazon.aws-7 SUCCESS in 20m 12s
✔️ integration-amazon.aws-8 SUCCESS in 41m 24s
✔️ integration-amazon.aws-9 SUCCESS in 51m 46s
✔️ integration-amazon.aws-10 SUCCESS in 41m 32s
✔️ integration-amazon.aws-11 SUCCESS in 38m 10s
✔️ integration-amazon.aws-12 SUCCESS in 13m 54s
integration-amazon.aws-13 FAILURE in 28m 46s
✔️ integration-amazon.aws-14 SUCCESS in 36m 04s
✔️ integration-amazon.aws-15 SUCCESS in 51m 18s
✔️ integration-amazon.aws-16 SUCCESS in 41m 57s
✔️ integration-amazon.aws-17 SUCCESS in 46m 54s
✔️ integration-amazon.aws-18 SUCCESS in 37m 23s
✔️ integration-amazon.aws-19 SUCCESS in 36m 37s
✔️ integration-amazon.aws-20 SUCCESS in 22m 50s
✔️ integration-amazon.aws-21 SUCCESS in 37m 18s
✔️ integration-amazon.aws-22 SUCCESS in 22m 57s
Skipped 22 jobs

@tremble
Copy link
Contributor Author

tremble commented Sep 22, 2023

regate

@softwarefactory-project-zuul
Copy link
Contributor

Build failed (gate pipeline). For information on how to proceed, see
http://docs.openstack.org/infra/manual/developers.html#automated-testing

https://ansible.softwarefactory-project.io/zuul/buildset/e1725eaadb1a4968b66bc26df9554c7c

✔️ ansible-galaxy-importer SUCCESS in 3m 47s
✔️ build-ansible-collection SUCCESS in 12m 45s
✔️ ansible-test-splitter SUCCESS in 5m 22s
✔️ integration-amazon.aws-1 SUCCESS in 28m 19s
✔️ integration-amazon.aws-2 SUCCESS in 40m 22s
integration-amazon.aws-3 RETRY_LIMIT in 1m 44s
✔️ integration-amazon.aws-4 SUCCESS in 37m 53s
integration-amazon.aws-5 RETRY_LIMIT in 1m 43s
integration-amazon.aws-6 RETRY_LIMIT in 1m 45s
✔️ integration-amazon.aws-7 SUCCESS in 23m 09s
✔️ integration-amazon.aws-8 SUCCESS in 39m 56s
✔️ integration-amazon.aws-9 SUCCESS in 51m 06s
✔️ integration-amazon.aws-10 SUCCESS in 43m 19s
✔️ integration-amazon.aws-11 SUCCESS in 43m 30s
✔️ integration-amazon.aws-12 SUCCESS in 15m 38s
integration-amazon.aws-13 FAILURE in 31m 12s
✔️ integration-amazon.aws-14 SUCCESS in 27m 29s
✔️ integration-amazon.aws-15 SUCCESS in 45m 29s
✔️ integration-amazon.aws-16 SUCCESS in 35m 53s
✔️ integration-amazon.aws-17 SUCCESS in 42m 50s
✔️ integration-amazon.aws-18 SUCCESS in 40m 23s
✔️ integration-amazon.aws-19 SUCCESS in 45m 10s
✔️ integration-amazon.aws-20 SUCCESS in 30m 37s
✔️ integration-amazon.aws-21 SUCCESS in 33m 15s
✔️ integration-amazon.aws-22 SUCCESS in 20m 38s
Skipped 22 jobs

Integration tests - Drop use of ec2_region

SUMMARY
Follow up to ansible-collections#1714
missed "ec2_region"
ISSUE TYPE

Docs Pull Request

COMPONENT NAME
tests/
ADDITIONAL INFORMATION

Reviewed-by: Alina Buzachis
…ollections#1714)

Mass update of docs and tests (credentials/session tokens)

SUMMARY
We had a cleanup of credentials/session parameters which included a batch of deprecations and renames.
Ensure that all of our tests and docs are using the 'canonical' names
ISSUE TYPE

Docs Pull Request

COMPONENT NAME
plugins/inventory/aws_ec2.py
plugins/lookup/secretsmanager_secret.py
plugins/lookup/ssm_parameter.py
plugins/modules/ec2_security_group.py
tests/integration/targets
ADDITIONAL INFORMATION
See Also: ansible-collections#1172

Reviewed-by: Alina Buzachis
Reviewed-by: Mark Chappell
@tremble tremble force-pushed the backport/stable-6/1714-and-1721 branch from 3f92ca8 to 3e0da8d Compare September 27, 2023 07:34
@softwarefactory-project-zuul
Copy link
Contributor

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/f0293bdda7a8420d9149ffddc8fdcff7

✔️ ansible-galaxy-importer SUCCESS in 3m 47s
✔️ build-ansible-collection SUCCESS in 12m 25s
✔️ ansible-test-splitter SUCCESS in 4m 41s
✔️ integration-amazon.aws-1 SUCCESS in 27m 26s
✔️ integration-amazon.aws-2 SUCCESS in 40m 01s
✔️ integration-amazon.aws-3 SUCCESS in 27m 15s
✔️ integration-amazon.aws-4 SUCCESS in 44m 02s
✔️ integration-amazon.aws-5 SUCCESS in 31m 07s
integration-amazon.aws-6 TIMED_OUT in 1h 00m 54s
✔️ integration-amazon.aws-7 SUCCESS in 22m 05s
✔️ integration-amazon.aws-8 SUCCESS in 39m 15s
✔️ integration-amazon.aws-9 SUCCESS in 45m 55s
✔️ integration-amazon.aws-10 SUCCESS in 45m 41s
✔️ integration-amazon.aws-11 SUCCESS in 38m 29s
✔️ integration-amazon.aws-12 SUCCESS in 17m 58s
✔️ integration-amazon.aws-13 SUCCESS in 24m 35s
integration-amazon.aws-14 RETRY_LIMIT in 7m 49s
integration-amazon.aws-15 RETRY_LIMIT in 1m 45s
✔️ integration-amazon.aws-16 SUCCESS in 39m 01s
✔️ integration-amazon.aws-17 SUCCESS in 45m 44s
integration-amazon.aws-18 FAILURE in 43m 18s
✔️ integration-amazon.aws-19 SUCCESS in 45m 58s
✔️ integration-amazon.aws-20 SUCCESS in 25m 44s
✔️ integration-amazon.aws-21 SUCCESS in 36m 16s
✔️ integration-amazon.aws-22 SUCCESS in 22m 53s
Skipped 22 jobs

@tremble
Copy link
Contributor Author

tremble commented Sep 29, 2023

Manual merge - CI flakes

@tremble tremble merged commit 0043c06 into ansible-collections:stable-6 Sep 29, 2023
34 of 35 checks passed
@tremble tremble deleted the backport/stable-6/1714-and-1721 branch January 12, 2024 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mergeit Merge the PR (SoftwareFactory)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants