[PR #1813/985d8b1c backport][stable-6] s3_object - fix NoSuchTagSet error when S3 endpoint doesn't support tags #1814
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![patchback[bot]](https://avatars.githubusercontent.com/in/21488?s=60&v=4){kind=small}
…ags (#1813) s3_object - fix NoSuchTagSet error when S3 endpoint doesn't support tags SUMMARY is_boto3_error_code only supports being passed a string or list. In the refactor of s3_object it was passed a tuple, so the errors weren't being cleanly caught. ISSUE TYPE Bugfix Pull Request COMPONENT NAME s3_object ADDITIONAL INFORMATION fixes: #1607 Reviewed-by: Alina Buzachis (cherry picked from commit 985d8b1)
|
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 3m 36s |
tremble
approved these changes
Oct 20, 2023
|
Build succeeded (gate pipeline). ✔️ ansible-galaxy-importer SUCCESS in 5m 27s |
softwarefactory-project-zuul
bot
merged commit ccb0af5
into
stable-6
63 of 91 checks passed
softwarefactory-project-zuul
bot
deleted the
patchback/backports/stable-6/985d8b1cffb2bc2ee71f28afaad80612e7282d4a/pr-1813
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of PR #1813 as merged into main (985d8b1).
SUMMARY
is_boto3_error_code only supports being passed a string or list. In the refactor of s3_object it was passed a tuple, so the errors weren't being cleanly caught.
ISSUE TYPE
COMPONENT NAME
s3_object
ADDITIONAL INFORMATION
fixes: #1607