Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor ec2_eip* modules #2165

Merged
merged 1 commit into from
Jul 15, 2024
Merged

Refactor ec2_eip* modules #2165

merged 1 commit into from
Jul 15, 2024

Conversation

abikouo
Copy link
Contributor

@abikouo abikouo commented Jul 1, 2024

SUMMARY

Refactor ec2_eip,ec2_eip_info modules

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

ec2_eip ec2_eip_info

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/a1546cce045543748bd3d26bc0be440b

✔️ ansible-galaxy-importer SUCCESS in 3m 25s
✔️ build-ansible-collection SUCCESS in 15m 55s
✔️ ansible-test-splitter SUCCESS in 6m 47s
❌ integration-amazon.aws-1 FAILURE in 6m 52s
Skipped 43 jobs

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/4d53ca6c0b0b4fde83c0e9c1eba8c7ae

✔️ ansible-galaxy-importer SUCCESS in 3m 21s
✔️ build-ansible-collection SUCCESS in 15m 38s
✔️ ansible-test-splitter SUCCESS in 6m 38s
✔️ integration-amazon.aws-1 SUCCESS in 9m 36s
Skipped 43 jobs

hakbailey
hakbailey reviewed Jul 6, 2024
View reviewed changes
plugins/modules/ec2_eip_info.py Outdated Show resolved Hide resolved
plugins/modules/ec2_eip_info.py Outdated Show resolved Hide resolved
plugins/modules/ec2_eip.py Outdated Show resolved Hide resolved
plugins/modules/ec2_eip.py Outdated Show resolved Hide resolved
plugins/modules/ec2_eip.py Outdated Show resolved Hide resolved
@abikouo abikouo requested a review from hakbailey July 8, 2024 11:53
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/9d401b85080e4340bdbcb853827f3f0a

✔️ ansible-galaxy-importer SUCCESS in 8m 18s
✔️ build-ansible-collection SUCCESS in 12m 42s
✔️ ansible-test-splitter SUCCESS in 5m 06s
✔️ integration-amazon.aws-1 SUCCESS in 9m 17s
Skipped 43 jobs

alinabuzachis
alinabuzachis approved these changes Jul 10, 2024
View reviewed changes
plugins/modules/ec2_eip.py Outdated Show resolved Hide resolved
plugins/modules/ec2_eip.py Outdated Show resolved Hide resolved
@abikouo abikouo force-pushed the refactor-modules-ec2_eip-2401071447 branch from 3dc305a to 30cc0e2 Compare July 10, 2024 13:41
@abikouo abikouo requested a review from alinabuzachis July 10, 2024 13:41
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/d712466825ea42f986a2464d43c30f48

✔️ ansible-galaxy-importer SUCCESS in 3m 54s
✔️ build-ansible-collection SUCCESS in 12m 51s
✔️ ansible-test-splitter SUCCESS in 5m 07s
✔️ integration-amazon.aws-1 SUCCESS in 10m 07s
Skipped 43 jobs

@abikouo abikouo force-pushed the refactor-modules-ec2_eip-2401071447 branch from 30cc0e2 to 7204897 Compare July 11, 2024 10:23
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/ede3fc7b8d854765a84cd4b5d1ae4de9

✔️ ansible-galaxy-importer SUCCESS in 4m 23s
✔️ build-ansible-collection SUCCESS in 12m 30s
✔️ ansible-test-splitter SUCCESS in 4m 56s
✔️ integration-amazon.aws-1 SUCCESS in 9m 38s
Skipped 43 jobs

@abikouo abikouo force-pushed the refactor-modules-ec2_eip-2401071447 branch from 7204897 to 093dad5 Compare July 11, 2024 10:48
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/a0e7b82e04ac4f8ba5ff6a5854c58932

✔️ ansible-galaxy-importer SUCCESS in 4m 39s
✔️ build-ansible-collection SUCCESS in 12m 25s
✔️ ansible-test-splitter SUCCESS in 4m 53s
✔️ integration-amazon.aws-1 SUCCESS in 9m 31s
Skipped 43 jobs

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/686b513c10334ed1ad689fff2d65e81f

✔️ ansible-galaxy-importer SUCCESS in 4m 33s
✔️ build-ansible-collection SUCCESS in 12m 29s
✔️ ansible-test-splitter SUCCESS in 5m 03s
✔️ integration-amazon.aws-1 SUCCESS in 9m 27s
Skipped 43 jobs

@abikouo abikouo force-pushed the refactor-modules-ec2_eip-2401071447 branch from 875d3e0 to a034253 Compare July 15, 2024 16:52
@abikouo abikouo added the mergeit Merge the PR (SoftwareFactory) label Jul 15, 2024
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).
https://ansible.softwarefactory-project.io/zuul/buildset/58a685590b8f44bb8b6f50fa6f691a8e

✔️ ansible-galaxy-importer SUCCESS in 3m 59s
✔️ build-ansible-collection SUCCESS in 12m 33s
✔️ ansible-test-splitter SUCCESS in 5m 08s
✔️ integration-amazon.aws-1 SUCCESS in 10m 35s
Skipped 43 jobs

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit bc6714c into ansible-collections:main Jul 15, 2024
35 of 36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alinabuzachis alinabuzachis alinabuzachis approved these changes

@hakbailey hakbailey hakbailey approved these changes

Assignees
No one assigned
Labels
mergeit Merge the PR (SoftwareFactory)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@abikouo @hakbailey @alinabuzachis