Migrate ec2 instance modules

[jillr]

SUMMARY

Moves ec2_instance and ec2_instance_info from community.aws to amazon.aws via git patch.

ISSUE TYPE

• New Module Pull Request

COMPONENT NAME

ec2_instance
ec2_instance_info

ADDITIONAL INFORMATION

This is the first time we're doing this, git history should be preserved but Github may want to squash. I don't love the idea of directly committing to origin to get around that. ETA: I should be able to do a manual merge from the cli though?

Migration was done via:

COLLECTIONS_PATH/community/aws$ git log --pretty=email --patch-with-stat --reverse --full-index --binary -- tests/integration/targets/ec2_instance/ plugins/modules/ec2_instance.py plugins/modules/ec2_instance_info.py > /tmp/patch`

COLLECTIONS_PATH/amazon/aws$ git am < /tmp/patch

then adding the _facts.py symlink and sed'ing the FQCNs.
A PR will follow to remove the modules from community.aws after this has merged.

[tremble]

recheck

[tremble]

A couple of nits. I also don't see an update to the module_defaults.

If at all possible I would rather see this land including the history. To me the history is extremely valuable and I have missed on multiple occasions having the original ansible/ansible history available to me (without making multiple queries)

[tremble]

@goneri Looks like the tests didn't trigger again

[alinabuzachis]

prepare_tests includes an empty file. Why do we need it?

[jillr]

TBH that's been migrated around as-is since it was in ansible/ansible. It would probably we good to do a general review but I'd prefer not to make too many changes here beyond what's needed to get the modules working

[jillr]

I"m going to try a cli merge. If anything goes wrong (ie, history is squashed) we can revert. (after a fresh rebase onto main)

[alinabuzachis]

LGTM (the integration tests that are skipped).

[jillr]

The git cli won't actually work for this, it wants to either squash or merge. After discussing with @gravesm and @goneri our options here are:

1. Squash. In this case we lose all the git history from community.aws - this means folks need to look at up to 3 repos (amazon.aws, community.aws, ansible/ansible) to trace the history of changes. Very not ideal.
2. Merge commit. None of us like this option as it makes git log messy.
3. Reproduce the git patching process that was done on this branch, and that we approve of the resulting effect of, directly onto main (in my local checkout) and push that to origin (ansible-collections/amazon.aws/tree/main). Then update/rebase this PR so that it should just include the docs updates and the 's/community.aws/amazon.aws/' pieces. We also don't love this option, but it seems to be the one that leaves us with the cleanest git history.

[tremble]

FWIW I'd probably go with option 3:

• Keeps the history
• Results in a single additional commit with the things specifically related to the migration.

[jillr]

Patched the files from community onto main (eek!) will cleanup the conflicts here and see how it goes