Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update user guide #417

Merged
merged 1 commit into from
Aug 13, 2021
Merged

Conversation

jillr
Copy link
Contributor

@jillr jillr commented Jul 23, 2021

SUMMARY

Swap out ec2.py examples for ec2_instance. Add information about using boto
profiles and module_defaults.

ISSUE TYPE
  • Docs Pull Request
COMPONENT NAME

guide_aws.rst

Depends-On: ansible/ansible-zuul-jobs#1041
Depends-On: ansible/ansible-zuul-jobs#1043

Swap out ec2.py examples for ec2_instance. Add information about using boto
profiles and module_defaults.
@jillr
Copy link
Contributor Author

jillr commented Jul 27, 2021

recheck

@jillr jillr requested a review from tremble July 27, 2021 17:35
Copy link
Contributor

@tremble tremble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ec2_access_key: "--REMOVED--"
ec2_secret_key: "--REMOVED--"
aws_access_key: "--REMOVED--"
aws_secret_key: "--REMOVED--"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we mention aws_session_token ?

@jillr
Copy link
Contributor Author

jillr commented Aug 2, 2021

recheck

2 similar comments
@pabelanger
Copy link
Contributor

recheck

@pabelanger
Copy link
Contributor

recheck

@pabelanger
Copy link
Contributor

@jillr @tremble what I would suggest here, is changes are being made to docs folder, to skip integration testing as a way to save resources.

@pabelanger
Copy link
Contributor

@pabelanger
Copy link
Contributor

recheck

1 similar comment
@pabelanger
Copy link
Contributor

recheck

Copy link
Contributor

@ansible-zuul ansible-zuul bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ansible-zuul ansible-zuul bot merged commit c9270e7 into ansible-collections:main Aug 13, 2021
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Sep 18, 2023
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Sep 18, 2023
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants