Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update plugins/modules/ec2_vol.py #474

Merged
merged 3 commits into from
Aug 27, 2021
Merged

Update plugins/modules/ec2_vol.py #474

merged 3 commits into from
Aug 27, 2021

Conversation

lowlydba
Copy link
Contributor

SUMMARY

Fix grammatical error in docs - modify --> modified

ISSUE TYPE
  • Docs Pull Request
COMPONENT NAME

ec2_vol

@ansibullbot ansibullbot added community_review docs needs_triage new_contributor Help guide this first time contributor small_patch Hopefully easy to review labels Aug 27, 2021
@tremble

This comment has been minimized.

Sign in to view
tremble
tremble requested changes Aug 27, 2021
View reviewed changes
Copy link
Contributor

@tremble tremble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @lowlydba,

Thanks for submitting this PR. The RST files are automatically generated from the modules, could you update ec2_vol.py (https://github.com/ansible-collections/amazon.aws/blob/main/plugins/modules/ec2_vol.py#L95) instead of this RST file.

@ansibullbot
Copy link

cc @jillr @lwade @s-hertel @wimnat
click here for bot help

@ansibullbot ansibullbot added module module plugins plugin (any type) and removed needs_triage small_patch Hopefully easy to review labels Aug 27, 2021
@tremble
Copy link
Contributor

tremble commented Aug 27, 2021

recheck

@lowlydba lowlydba changed the title Update amazon.aws.ec2_vol_module.rst Update plugins/modules/ec2_vol.py Aug 27, 2021
@tremble tremble added the gate label Aug 27, 2021
ansible-zuul[bot]
ansible-zuul bot approved these changes Aug 27, 2021
View reviewed changes
Copy link
Contributor

@ansible-zuul ansible-zuul bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ansible-zuul ansible-zuul bot merged commit e8df917 into ansible-collections:main Aug 27, 2021
goneri pushed a commit to goneri/amazon.aws that referenced this pull request Aug 28, 2021
@felixfontein @alinabuzachis
More no_log=False to fix sanity tests (ansible-collections#474)
f5ec6d2 
* Add no_log=False to mark some more false-positives of the no_log check.

* More false-positives confirmed by tremble.

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@67b6d75
goneri pushed a commit to goneri/amazon.aws that referenced this pull request Aug 28, 2021
@felixfontein @jillr
More no_log=False to fix sanity tests (ansible-collections#474)
7f3a941 
* Add no_log=False to mark some more false-positives of the no_log check.

* More false-positives confirmed by tremble.

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@67b6d75
goneri pushed a commit to goneri/amazon.aws that referenced this pull request Sep 6, 2022
@felixfontein @goneri
More no_log=False to fix sanity tests (ansible-collections#474)
d3b30ea 
* Add no_log=False to mark some more false-positives of the no_log check.

* More false-positives confirmed by tremble.

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@67b6d75
goneri pushed a commit to goneri/amazon.aws that referenced this pull request Sep 7, 2022
@felixfontein @goneri
More no_log=False to fix sanity tests (ansible-collections#474)
f375a12 
* Add no_log=False to mark some more false-positives of the no_log check.

* More false-positives confirmed by tremble.

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@67b6d75
GomathiselviS pushed a commit to GomathiselviS/amazon.aws that referenced this pull request Sep 7, 2022
@felixfontein @GomathiselviS
More no_log=False to fix sanity tests (ansible-collections#474)
24f690e 
* Add no_log=False to mark some more false-positives of the no_log check.

* More false-positives confirmed by tremble.

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@67b6d75
goneri pushed a commit to goneri/amazon.aws that referenced this pull request Sep 9, 2022
@felixfontein @goneri
More no_log=False to fix sanity tests (ansible-collections#474)
f267b0b 
* Add no_log=False to mark some more false-positives of the no_log check.

* More false-positives confirmed by tremble.

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@67b6d75
alinabuzachis pushed a commit to alinabuzachis/amazon.aws that referenced this pull request Sep 16, 2022
@felixfontein @alinabuzachis
More no_log=False to fix sanity tests (ansible-collections#474)
5371d50 
* Add no_log=False to mark some more false-positives of the no_log check.

* More false-positives confirmed by tremble.

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@67b6d75
alinabuzachis pushed a commit to alinabuzachis/amazon.aws that referenced this pull request Sep 16, 2022
@felixfontein @alinabuzachis
More no_log=False to fix sanity tests (ansible-collections#474)
7d4d006 
* Add no_log=False to mark some more false-positives of the no_log check.

* More false-positives confirmed by tremble.

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@67b6d75
goneri pushed a commit to alinabuzachis/amazon.aws that referenced this pull request Sep 21, 2022
@felixfontein @goneri
More no_log=False to fix sanity tests (ansible-collections#474)
49e80a8 
* Add no_log=False to mark some more false-positives of the no_log check.

* More false-positives confirmed by tremble.

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@67b6d75
goneri pushed a commit to alinabuzachis/amazon.aws that referenced this pull request Sep 21, 2022
@felixfontein @goneri
More no_log=False to fix sanity tests (ansible-collections#474)
7be748f 
* Add no_log=False to mark some more false-positives of the no_log check.

* More false-positives confirmed by tremble.

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@67b6d75
goneri pushed a commit to alinabuzachis/amazon.aws that referenced this pull request Sep 21, 2022
@felixfontein @goneri
More no_log=False to fix sanity tests (ansible-collections#474)
d915ef5 
* Add no_log=False to mark some more false-positives of the no_log check.

* More false-positives confirmed by tremble.

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@67b6d75
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Sep 18, 2023
@felixfontein
More no_log=False to fix sanity tests (ansible-collections#474)
628e91b 
* Add no_log=False to mark some more false-positives of the no_log check.

* More false-positives confirmed by tremble.
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Sep 18, 2023
@felixfontein @abikouo
More no_log=False to fix sanity tests (ansible-collections#474)
90ab23a 
* Add no_log=False to mark some more false-positives of the no_log check.

* More false-positives confirmed by tremble.
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Oct 24, 2023
@felixfontein
More no_log=False to fix sanity tests (ansible-collections#474)
67b6d75 
* Add no_log=False to mark some more false-positives of the no_log check.

* More false-positives confirmed by tremble.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ansible-zuul ansible-zuul[bot] ansible-zuul[bot] approved these changes

@tremble tremble tremble approved these changes

Assignees
No one assigned
Labels
community_review docs module module new_contributor Help guide this first time contributor plugins plugin (any type)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lowlydba @tremble @ansibullbot