Refactor test code for fetching AMIs and AZs #485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibullbot
added
WIP
tremble
force-pushed
the
test_facts_refactor
branch
from
f745df1 to
7cc03bf
Compare
tremble
changed the title
|
@goneri I mentioned standardizing on a single AMI this is my suggestion of how to implement |
|
I tend to think we can just declare a region/AMI mapping and avoid the logic to auto-guess the right image. |
goneri
approved these changes
Aug 31, 2021
![ansible-zuul[bot]](https://avatars.githubusercontent.com/in/27800?s=60&v=4){kind=small}
ansibullbot
added
needs_rebase
tremble
force-pushed
the
test_facts_refactor
branch
from
7cc03bf to
d52de48
Compare
ansibullbot
added
community_review
module
tremble
force-pushed
the
test_facts_refactor
branch
from
295a0dc to
6fe0ec5
Compare
tremble
force-pushed
the
test_facts_refactor
branch
from
6fe0ec5 to
b4f9b64
Compare
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Oct 24, 2023
) * fix test bugs * Update tests/integration/targets/aws_acm/tasks/full_acm_test.yml Co-authored-by: Mark Chappell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Our Tests have a lot of copy and paste code, let's try refactoring a little. This also means we're more consistent about which AMIs we use.
ISSUE TYPE
COMPONENT NAME
cloudformation
ec2
ec2_ami
ec2_eni
ec2_vol
ec2_vpc_route_table
ec2_vpc_subnet
ADDITIONAL INFORMATION