Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport - Fixup / ignore new pylint 2.9.3 issues #491

Merged

Conversation

tremble
Copy link
Contributor

@tremble tremble commented Sep 6, 2021

SUMMARY

The containers have been updated to include a new version of pylint ( ansible-collections/overview#45 )
fixup arguments-renamed
ignore pylint:use-a-generator (an easy fix but not worth blocking gating)

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

tests/unit/mock/loader.py
tests/unit/module_utils/test_elbv2.py

ADDITIONAL INFORMATION

Backport of #460
Depends-On: ansible/ansible-zuul-jobs#1097

…s#460)

The devel containers have been updated to include a new version of pylint ( ansible-collections/overview#45 (comment) )
fixup arguments-renamed
ignore pylint:use-a-generator (Should be an easy fix but not worth blocking gating)
@ansibullbot
Copy link

@alinabuzachis
Copy link
Collaborator

recheck

1 similar comment
@tremble
Copy link
Contributor Author

tremble commented Sep 7, 2021

recheck

@jillr
Copy link
Collaborator

jillr commented Sep 7, 2021

recheck

1 similar comment
@alinabuzachis
Copy link
Collaborator

recheck

@tremble tremble added the gate label Sep 8, 2021
Copy link
Contributor

@ansible-zuul ansible-zuul bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ansible-zuul ansible-zuul bot merged commit f309a46 into ansible-collections:stable-1.5 Sep 8, 2021
ansible-zuul bot pushed a commit that referenced this pull request Sep 9, 2021
#371) (#479)

ec2_vol: backport to stable-1.5 to fix modify_volume size option bug

SUMMARY

Back port to stable-1.5 to fix a bug in  modify_volume, 'size' option.

Fixes #471.
ISSUE TYPE


Bugfix Pull Request

COMPONENT NAME

ec2_vol
ADDITIONAL INFORMATION



Required fix was done but was not applied in 1.5.0 release.
For more details, please visit #471.

Backports: #371
Depends-On: #491

Reviewed-by: Jill R <None>
Reviewed-by: Alina Buzachis <None>
Reviewed-by: None <None>
ansible-zuul bot pushed a commit that referenced this pull request Sep 9, 2021
ec2_vol: backport fix incorrectly returned changed result

SUMMARY
Backport version of #483
When modify_volume is used but no new disk is being attached, the module incorrectly reports that no change has occurred even when disks have been modified (iops, throughput, type, etc.). This is due to the attach function overwriting the changed variable even if no disks are attached.
Fixes #482
The integration test has been fixed so that when the gp3 modifications are tested, the volume is already in an attached state (previously detached) when reporting back changed. The detach tests are moved further down now, allowing this case to be properly covered by the existing assert:

  
    
      amazon.aws/tests/integration/targets/ec2_vol/tasks/tests.yml
    
    
        Lines 384 to 387
      in
      e8df917
    
    
    
    

        
          
           - name: check that volume_type has changed 
        

        
          
             assert: 
        

        
          
               that: 
        

        
          
                 - changed_gp3_volume.changed 
        
    
  


ISSUE TYPE


Bugfix Pull Request

COMPONENT NAME
ec2_vol
Depends-On: #491

Reviewed-by: Mark Chappell <None>
Reviewed-by: Alina Buzachis <None>
Reviewed-by: None <None>
@tremble tremble deleted the backport/1.5/460 branch November 26, 2021 12:43
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Sep 18, 2023
Fix cloudfront_distribution disabling ipv6 when updating resource

Reviewed-by: https://github.com/apps/ansible-zuul
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Oct 24, 2023
Fix cloudfront_distribution disabling ipv6 when updating resource

Reviewed-by: https://github.com/apps/ansible-zuul
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue/PR relates to a bug community_review integration tests/integration plugins plugin (any type) tests tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants