[PR #592/a2be6da7 backport][stable-2] elb_classic_lb: fix - resolve security_group_ids when providing security_group_names #594
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![patchback[bot]](https://avatars.githubusercontent.com/in/21488?s=60&v=4){kind=small}
…ity_group_names (#592) elb_classic_lb: fix - resolve security_group_ids when providing security_group_names SUMMARY Fix failed to resolve security_group_ids when providing security_group_names. Fix broken tasks in integration tests. Fixes #589. ISSUE TYPE Bugfix Pull Request COMPONENT NAME elb_classic_lb Reviewed-by: Mark Chappell <None> Reviewed-by: None <None> (cherry picked from commit a2be6da)
jillr
approved these changes
Jan 12, 2022
![ansible-zuul[bot]](https://avatars.githubusercontent.com/in/27800?s=60&v=4){kind=small}
ansible-zuul
bot
deleted the
patchback/backports/stable-2/a2be6da7f4169527493ab2ec4ff061eb4d85ac7b/pr-592
branch
|
This fix doesn't work, if the ELB doesn't exist. The suggested fix in #589 does actually work. |
Closed
1 task
| @@ -744,7 +744,7 @@ def __init__(self, module): | |||
| if security_group_names: | |||
| # Use the subnets attached to the VPC to find which VPC we're in and | |||
| # limit the search | |||
| if self.elb.get('Subnets'): | |||
| if self.elb.get('Subnets', None): | |||
There was a problem hiding this comment.
Fails if ELB doesn't exsist (even if called with state: absent)
elb is undefined. get() throws error.
Replace with:
if self.elb is not None and self.elb.get('Subnets', None):
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of PR #592 as merged into main (a2be6da).
SUMMARY
Fix failed to resolve security_group_ids when providing security_group_names.
Fix broken tasks in integration tests.
Fixes #589.
ISSUE TYPE
COMPONENT NAME
elb_classic_lb