Disable broken integration test - lookup_aws_account_attribute #682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…le-collections#632) Disable broken integration test - lookup_aws_account_attribute SUMMARY After going through the joys of bisecting recent changes ansible/ansible#75587 appears to have broken the test when running 'wantlist=False' ISSUE TYPE Feature Pull Request COMPONENT NAME aws_account_attribute ADDITIONAL INFORMATION TASK [lookup_aws_account_attribute : Fetch all account attributes (wantlist=False)] ******************************************************************************************************************************* task path: /root/ansible_collections/amazon/aws/tests/output/.tmp/integration/lookup_aws_account_attribute-bjtiq49h-ÅÑŚÌβŁÈ/tests/integration/targets/lookup_aws_account_attribute/tasks/main.yaml:50 The full traceback is: Traceback (most recent call last): File "/root/ansible/lib/ansible/executor/task_executor.py", line 503, in _execute self._task.post_validate(templar=templar) File "/root/ansible/lib/ansible/playbook/task.py", line 283, in post_validate super(Task, self).post_validate(templar) File "/root/ansible/lib/ansible/playbook/base.py", line 650, in post_validate value = templar.template(getattr(self, name)) File "/root/ansible/lib/ansible/template/__init__.py", line 874, in template d[k] = self.template( File "/root/ansible/lib/ansible/template/__init__.py", line 842, in template result = self.do_template( File "/root/ansible/lib/ansible/template/__init__.py", line 1101, in do_template res = ansible_concat(rf, convert_data, myenv.variable_start_string) File "/root/ansible/lib/ansible/template/native_helpers.py", line 60, in ansible_concat head = list(islice(nodes, 2)) File "<template>", line 13, in root File "/usr/lib/python3.10/dist-packages/jinja2/runtime.py", line 349, in call return __obj(*args, **kwargs) File "/root/ansible/lib/ansible/template/__init__.py", line 1013, in _lookup if isinstance(ran[0], NativeJinjaText): KeyError: 0 fatal: [testhost]: FAILED! => { "changed": false } Reviewed-by: Alina Buzachis <None> Reviewed-by: None <None>
ansibullbot
added
bug
|
Build failed.
|
|
recheck |
|
Build succeeded.
|
|
Build succeeded (gate pipeline).
|
softwarefactory-project-zuul
bot
merged commit 78a7a29
into
ansible-collections:stable-2
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Sep 18, 2023
…s3_bucket_info aws_s3_bucket_info - Add a check for botocore>='1.18.11' when pulling bucket_ownership_controls SUMMARY Fetching bucket_ownership_controls requires botocore>='1.18.11' add a check and update the tests to explicitly require this version of botocore when testing accessing bucket_ownership_controls ISSUE TYPE Bugfix Pull Request COMPONENT NAME aws_s3_bucket_info ADDITIONAL INFORMATION Depends-On: ansible-collections#686 Reviewed-by: Alina Buzachis <None> Reviewed-by: None <None>
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Oct 24, 2023
…s3_bucket_info aws_s3_bucket_info - Add a check for botocore>='1.18.11' when pulling bucket_ownership_controls SUMMARY Fetching bucket_ownership_controls requires botocore>='1.18.11' add a check and update the tests to explicitly require this version of botocore when testing accessing bucket_ownership_controls ISSUE TYPE Bugfix Pull Request COMPONENT NAME aws_s3_bucket_info ADDITIONAL INFORMATION Depends-On: ansible-collections#686 Reviewed-by: Alina Buzachis <None> Reviewed-by: None <None>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disable broken integration test - lookup_aws_account_attribute
SUMMARY
After going through the joys of bisecting recent changes ansible/ansible#75587 appears to have broken the test when running 'wantlist=False'
ISSUE TYPE
Feature Pull Request
COMPONENT NAME
aws_account_attribute
ADDITIONAL INFORMATION
Reviewed-by: Alina Buzachis
Reviewed-by: None
SUMMARY
ISSUE TYPE
COMPONENT NAME
ADDITIONAL INFORMATION