[PR #590/b27f5167 backport][stable-1.5] Fix tempfolder path since Fedora uses tmpfs #773

patchback · 2022-04-13T07:13:54Z

This is a backport of PR #740 as merged into main (d3e81b7).

Don't compare strings with \n character. This triggers errors like this:

fatal: [testhost]: FAILED! => {
    "msg": "The conditional check 'result.contents == \"template:\ntest template\n\"' failed. The error was: Invalid conditional detected: EOL while scanning string literal (<unknown>, line 1)"
}

This is a backport of PR #590 as merged into main (b27f516).

SUMMARY

This is a fix for

2021-12-20 10:36:56.079435 \| fedora-35 \| TASK [aws_s3 : make tempfile 4 GB for linux] ***********************************
--
5391 | 2021-12-20 10:36:56.079637 \| fedora-35 \| task path: /home/zuul/.ansible/collections/ansible_collections/amazon/aws/tests/integration/targets/aws_s3/tasks/main.yml:499
5392 | 2021-12-20 10:36:56.244626 \| fedora-35 \| Using module file /tmp/ansible-test-qyqzaib3/ansible/modules/command.py
5393 | 2021-12-20 10:36:56.244945 \| fedora-35 \| Pipelining is enabled.
5394 | 2021-12-20 10:36:56.245217 \| fedora-35 \| <testhost> ESTABLISH LOCAL CONNECTION FOR USER: zuul
5395 | 2021-12-20 10:36:56.245359 \| fedora-35 \| <testhost> EXEC /bin/sh -c 'ANSIBLE_DEBUG_BOTOCORE_LOGS=True /home/zuul/venv/bin/python && sleep 0'
5396 | 2021-12-20 10:36:57.054748 \| fedora-35 \| fatal: [testhost]: FAILED! => {
5397 | 2021-12-20 10:36:57.054840 \| fedora-35 \|     "changed": true,
5398 | 2021-12-20 10:36:57.054850 \| fedora-35 \|     "cmd": [
5399 | 2021-12-20 10:36:57.054856 \| fedora-35 \|         "dd",
5400 | 2021-12-20 10:36:57.054862 \| fedora-35 \|         "if=/dev/zero",
5401 | 2021-12-20 10:36:57.054868 \| fedora-35 \|         "of=/tmp/ansible.6d71q1je/largefile",
5402 | 2021-12-20 10:36:57.054875 \| fedora-35 \|         "bs=1M",
5403 | 2021-12-20 10:36:57.054880 \| fedora-35 \|         "count=4096"
5404 | 2021-12-20 10:36:57.054886 \| fedora-35 \|     ],
5405 | 2021-12-20 10:36:57.054892 \| fedora-35 \|     "delta": "0:00:00.601860",
5406 | 2021-12-20 10:36:57.054897 \| fedora-35 \|     "end": "2021-12-20 10:36:57.021668",
5407 | 2021-12-20 10:36:57.054903 \| fedora-35 \|     "invocation": {
5408 | 2021-12-20 10:36:57.054909 \| fedora-35 \|         "module_args": {
5409 | 2021-12-20 10:36:57.054915 \| fedora-35 \|             "_raw_params": "dd if=/dev/zero of=/tmp/ansible.6d71q1je/largefile bs=1M count=4096",
5410 | 2021-12-20 10:36:57.054928 \| fedora-35 \|             "_uses_shell": false,
5411 | 2021-12-20 10:36:57.054935 \| fedora-35 \|             "argv": null,
5412 | 2021-12-20 10:36:57.054941 \| fedora-35 \|             "chdir": null,
5413 | 2021-12-20 10:36:57.054947 \| fedora-35 \|             "creates": null,
5414 | 2021-12-20 10:36:57.054953 \| fedora-35 \|             "executable": null,
5415 | 2021-12-20 10:36:57.054960 \| fedora-35 \|             "removes": null,
5416 | 2021-12-20 10:36:57.054966 \| fedora-35 \|             "stdin": null,
5417 | 2021-12-20 10:36:57.054972 \| fedora-35 \|             "stdin_add_newline": true,
5418 | 2021-12-20 10:36:57.054978 \| fedora-35 \|             "strip_empty_ends": true,
5419 | 2021-12-20 10:36:57.054984 \| fedora-35 \|             "warn": false
5420 | 2021-12-20 10:36:57.055001 \| fedora-35 \|         }
5421 | 2021-12-20 10:36:57.055007 \| fedora-35 \|     },
5422 | 2021-12-20 10:36:57.055012 \| fedora-35 \|     "msg": "non-zero return code",
5423 | 2021-12-20 10:36:57.055017 \| fedora-35 \|     "rc": 1,
5424 | 2021-12-20 10:36:57.055023 \| fedora-35 \|     "start": "2021-12-20 10:36:56.419808",
5425 | 2021-12-20 10:36:57.055030 \| fedora-35 \|     "stderr": "dd: error writing '/tmp/ansible.6d71q1je/largefile': No space left on device\n947+0 records in\n946+0 records out\n992100352 bytes (992 MB, 946 MiB) copied, 0.596905 s, 1.7 GB/s",
5426 | 2021-12-20 10:36:57.055037 \| fedora-35 \|     "stderr_lines": [
5427 | 2021-12-20 10:36:57.055043 \| fedora-35 \|         "dd: error writing '/tmp/ansible.6d71q1je/largefile': No space left on device",
5428 | 2021-12-20 10:36:57.055049 \| fedora-35 \|         "947+0 records in",
5429 | 2021-12-20 10:36:57.055054 \| fedora-35 \|         "946+0 records out",
5430 | 2021-12-20 10:36:57.055060 \| fedora-35 \|         "992100352 bytes (992 MB, 946 MiB) copied, 0.596905 s, 1.7 GB/s"
5431 | 2021-12-20 10:36:57.055066 \| fedora-35 \|     ],
5432 | 2021-12-20 10:36:57.055071 \| fedora-35 \|     "stdout": "",
5433 | 2021-12-20 10:36:57.055077 \| fedora-35 \|     "stdout_lines": []
5434 | 2021-12-20 10:36:57.055083 \| fedora-35 \| }

ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME

aws_s3

Fix tempfolder path since Fedora uses tmpfs SUMMARY This is a fix for 2021-12-20 10:36:56.079435 \| fedora-35 \| TASK [aws_s3 : make tempfile 4 GB for linux] *********************************** -- 5391 | 2021-12-20 10:36:56.079637 \| fedora-35 \| task path: /home/zuul/.ansible/collections/ansible_collections/amazon/aws/tests/integration/targets/aws_s3/tasks/main.yml:499 5392 | 2021-12-20 10:36:56.244626 \| fedora-35 \| Using module file /tmp/ansible-test-qyqzaib3/ansible/modules/command.py 5393 | 2021-12-20 10:36:56.244945 \| fedora-35 \| Pipelining is enabled. 5394 | 2021-12-20 10:36:56.245217 \| fedora-35 \| <testhost> ESTABLISH LOCAL CONNECTION FOR USER: zuul 5395 | 2021-12-20 10:36:56.245359 \| fedora-35 \| <testhost> EXEC /bin/sh -c 'ANSIBLE_DEBUG_BOTOCORE_LOGS=True /home/zuul/venv/bin/python && sleep 0' 5396 | 2021-12-20 10:36:57.054748 \| fedora-35 \| fatal: [testhost]: FAILED! => { 5397 | 2021-12-20 10:36:57.054840 \| fedora-35 \| "changed": true, 5398 | 2021-12-20 10:36:57.054850 \| fedora-35 \| "cmd": [ 5399 | 2021-12-20 10:36:57.054856 \| fedora-35 \| "dd", 5400 | 2021-12-20 10:36:57.054862 \| fedora-35 \| "if=/dev/zero", 5401 | 2021-12-20 10:36:57.054868 \| fedora-35 \| "of=/tmp/ansible.6d71q1je/largefile", 5402 | 2021-12-20 10:36:57.054875 \| fedora-35 \| "bs=1M", 5403 | 2021-12-20 10:36:57.054880 \| fedora-35 \| "count=4096" 5404 | 2021-12-20 10:36:57.054886 \| fedora-35 \| ], 5405 | 2021-12-20 10:36:57.054892 \| fedora-35 \| "delta": "0:00:00.601860", 5406 | 2021-12-20 10:36:57.054897 \| fedora-35 \| "end": "2021-12-20 10:36:57.021668", 5407 | 2021-12-20 10:36:57.054903 \| fedora-35 \| "invocation": { 5408 | 2021-12-20 10:36:57.054909 \| fedora-35 \| "module_args": { 5409 | 2021-12-20 10:36:57.054915 \| fedora-35 \| "_raw_params": "dd if=/dev/zero of=/tmp/ansible.6d71q1je/largefile bs=1M count=4096", 5410 | 2021-12-20 10:36:57.054928 \| fedora-35 \| "_uses_shell": false, 5411 | 2021-12-20 10:36:57.054935 \| fedora-35 \| "argv": null, 5412 | 2021-12-20 10:36:57.054941 \| fedora-35 \| "chdir": null, 5413 | 2021-12-20 10:36:57.054947 \| fedora-35 \| "creates": null, 5414 | 2021-12-20 10:36:57.054953 \| fedora-35 \| "executable": null, 5415 | 2021-12-20 10:36:57.054960 \| fedora-35 \| "removes": null, 5416 | 2021-12-20 10:36:57.054966 \| fedora-35 \| "stdin": null, 5417 | 2021-12-20 10:36:57.054972 \| fedora-35 \| "stdin_add_newline": true, 5418 | 2021-12-20 10:36:57.054978 \| fedora-35 \| "strip_empty_ends": true, 5419 | 2021-12-20 10:36:57.054984 \| fedora-35 \| "warn": false 5420 | 2021-12-20 10:36:57.055001 \| fedora-35 \| } 5421 | 2021-12-20 10:36:57.055007 \| fedora-35 \| }, 5422 | 2021-12-20 10:36:57.055012 \| fedora-35 \| "msg": "non-zero return code", 5423 | 2021-12-20 10:36:57.055017 \| fedora-35 \| "rc": 1, 5424 | 2021-12-20 10:36:57.055023 \| fedora-35 \| "start": "2021-12-20 10:36:56.419808", 5425 | 2021-12-20 10:36:57.055030 \| fedora-35 \| "stderr": "dd: error writing '/tmp/ansible.6d71q1je/largefile': No space left on device\n947+0 records in\n946+0 records out\n992100352 bytes (992 MB, 946 MiB) copied, 0.596905 s, 1.7 GB/s", 5426 | 2021-12-20 10:36:57.055037 \| fedora-35 \| "stderr_lines": [ 5427 | 2021-12-20 10:36:57.055043 \| fedora-35 \| "dd: error writing '/tmp/ansible.6d71q1je/largefile': No space left on device", 5428 | 2021-12-20 10:36:57.055049 \| fedora-35 \| "947+0 records in", 5429 | 2021-12-20 10:36:57.055054 \| fedora-35 \| "946+0 records out", 5430 | 2021-12-20 10:36:57.055060 \| fedora-35 \| "992100352 bytes (992 MB, 946 MiB) copied, 0.596905 s, 1.7 GB/s" 5431 | 2021-12-20 10:36:57.055066 \| fedora-35 \| ], 5432 | 2021-12-20 10:36:57.055071 \| fedora-35 \| "stdout": "", 5433 | 2021-12-20 10:36:57.055077 \| fedora-35 \| "stdout_lines": [] 5434 | 2021-12-20 10:36:57.055083 \| fedora-35 \| } ISSUE TYPE Bugfix Pull Request COMPONENT NAME aws_s3 Reviewed-by: None <None> Reviewed-by: Gonéri Le Bouder <[email protected]> Reviewed-by: None <None> (cherry picked from commit b27f516)

ansibullbot · 2022-04-13T07:21:18Z

cc @jillr @linabuzachis @lwade @s-hertel @tremble
click here for bot help

softwarefactory-project-zuul · 2022-04-13T07:35:40Z

Build failed.

ansible-galaxy-importer : SUCCESS in 5m 40s
build-ansible-collection : SUCCESS in 4m 07s
ansible-test-sanity-aws-ansible-python38 : SUCCESS in 9m 00s
ansible-test-sanity-aws-ansible-2.9-python38 : SUCCESS in 13m 12s
ansible-test-sanity-aws-ansible-2.11-python38 : SUCCESS in 9m 06s
ansible-test-units-amazon-aws-python38 : SUCCESS in 5m 40s
ansible-test-splitter : SUCCESS in 3m 55s
integration-amazon.aws-1 : FAILURE in 10m 41s
integration-amazon.aws-2 : SKIPPED
integration-amazon.aws-3 : SKIPPED
integration-amazon.aws-4 : SKIPPED
integration-amazon.aws-5 : SKIPPED
integration-amazon.aws-6 : SKIPPED
integration-amazon.aws-7 : SKIPPED
integration-amazon.aws-8 : SKIPPED
integration-amazon.aws-9 : SKIPPED
integration-amazon.aws-10 : SKIPPED
integration-amazon.aws-11 : SKIPPED
integration-amazon.aws-12 : SKIPPED
integration-amazon.aws-13 : SKIPPED
integration-community.aws-1 : SKIPPED
integration-community.aws-2 : SKIPPED
integration-community.aws-3 : SKIPPED
integration-community.aws-4 : SKIPPED
integration-community.aws-5 : SKIPPED
integration-community.aws-6 : SKIPPED
integration-community.aws-7 : SKIPPED
integration-community.aws-8 : SKIPPED
integration-community.aws-9 : SKIPPED
integration-community.aws-10 : SKIPPED
integration-community.aws-11 : SKIPPED
integration-community.aws-12 : SKIPPED
integration-community.aws-13 : SKIPPED
ansible-ee-tests-latest : FAILURE in 11m 10s (non-voting)
ansible-ee-tests-stable-2.9 : SUCCESS in 11m 34s
ansible-ee-tests-stable-2.11 : SUCCESS in 14m 27s
ansible-ee-tests-stable-2.12 : FAILURE in 15m 30s (non-voting)

aws_s3: simplify the template check Don't compare strings with \n character. This triggers errors like this: fatal: [testhost]: FAILED! => { "msg": "The conditional check 'result.contents == \"template:\ntest template\n\"' failed. The error was: Invalid conditional detected: EOL while scanning string literal (<unknown>, line 1)" } Reviewed-by: Alina Buzachis <None> (cherry picked from commit d3e81b7)

tremble · 2022-04-13T08:36:41Z

Added #740 to the backport.

softwarefactory-project-zuul · 2022-04-13T09:00:44Z

Build succeeded.

ansible-galaxy-importer : SUCCESS in 5m 02s
build-ansible-collection : SUCCESS in 3m 31s
ansible-test-sanity-aws-ansible-python38 : SUCCESS in 11m 10s
ansible-test-sanity-aws-ansible-2.9-python38 : SUCCESS in 11m 07s
ansible-test-sanity-aws-ansible-2.11-python38 : SUCCESS in 10m 39s
ansible-test-units-amazon-aws-python38 : SUCCESS in 6m 05s
ansible-test-splitter : SUCCESS in 3m 12s
integration-amazon.aws-1 : SUCCESS in 11m 03s
integration-amazon.aws-2 : SKIPPED
integration-amazon.aws-3 : SKIPPED
integration-amazon.aws-4 : SKIPPED
integration-amazon.aws-5 : SKIPPED
integration-amazon.aws-6 : SKIPPED
integration-amazon.aws-7 : SKIPPED
integration-amazon.aws-8 : SKIPPED
integration-amazon.aws-9 : SKIPPED
integration-amazon.aws-10 : SKIPPED
integration-amazon.aws-11 : SKIPPED
integration-amazon.aws-12 : SKIPPED
integration-amazon.aws-13 : SKIPPED
integration-community.aws-1 : SKIPPED
integration-community.aws-2 : SKIPPED
integration-community.aws-3 : SKIPPED
integration-community.aws-4 : SKIPPED
integration-community.aws-5 : SKIPPED
integration-community.aws-6 : SKIPPED
integration-community.aws-7 : SKIPPED
integration-community.aws-8 : SKIPPED
integration-community.aws-9 : SKIPPED
integration-community.aws-10 : SKIPPED
integration-community.aws-11 : SKIPPED
integration-community.aws-12 : SKIPPED
integration-community.aws-13 : SKIPPED
ansible-ee-tests-latest : FAILURE in 15m 05s (non-voting)
ansible-ee-tests-stable-2.9 : SUCCESS in 19m 14s
ansible-ee-tests-stable-2.11 : SUCCESS in 12m 22s
ansible-ee-tests-stable-2.12 : FAILURE in 14m 51s (non-voting)

softwarefactory-project-zuul · 2022-04-13T09:27:33Z

Build succeeded (gate pipeline).

ansible-galaxy-importer : SUCCESS in 5m 19s
build-ansible-collection : SUCCESS in 5m 23s
ansible-test-sanity-aws-ansible-python38 : SUCCESS in 9m 51s
ansible-test-sanity-aws-ansible-2.9-python38 : SUCCESS in 10m 31s
ansible-test-sanity-aws-ansible-2.11-python38 : SUCCESS in 9m 09s
ansible-test-units-amazon-aws-python38 : SUCCESS in 5m 51s
ansible-test-splitter : SUCCESS in 3m 31s
integration-amazon.aws-1 : SUCCESS in 10m 24s
integration-amazon.aws-2 : SKIPPED
integration-amazon.aws-3 : SKIPPED
integration-amazon.aws-4 : SKIPPED
integration-amazon.aws-5 : SKIPPED
integration-amazon.aws-6 : SKIPPED
integration-amazon.aws-7 : SKIPPED
integration-amazon.aws-8 : SKIPPED
integration-amazon.aws-9 : SKIPPED
integration-amazon.aws-10 : SKIPPED
integration-amazon.aws-11 : SKIPPED
integration-amazon.aws-12 : SKIPPED
integration-amazon.aws-13 : SKIPPED
integration-community.aws-1 : SKIPPED
integration-community.aws-2 : SKIPPED
integration-community.aws-3 : SKIPPED
integration-community.aws-4 : SKIPPED
integration-community.aws-5 : SKIPPED
integration-community.aws-6 : SKIPPED
integration-community.aws-7 : SKIPPED
integration-community.aws-8 : SKIPPED
integration-community.aws-9 : SKIPPED
integration-community.aws-10 : SKIPPED
integration-community.aws-11 : SKIPPED
integration-community.aws-12 : SKIPPED
integration-community.aws-13 : SKIPPED
ansible-ee-tests-latest : FAILURE in 14m 22s (non-voting)
ansible-ee-tests-stable-2.9 : SUCCESS in 16m 16s
ansible-ee-tests-stable-2.11 : SUCCESS in 12m 00s
ansible-ee-tests-stable-2.12 : FAILURE in 15m 26s (non-voting)

elb_instance - boto3 migration SUMMARY Migrate elb_instance to boto3 ISSUE TYPE Feature Pull Request COMPONENT NAME elb_instance ADDITIONAL INFORMATION Depends-On: ansible/ansible-zuul-jobs#1200 Reviewed-by: Jill R <None> Reviewed-by: Mark Chappell <None> Reviewed-by: Alina Buzachis <None> Reviewed-by: None <None>

elb_instance - remove ec2_elbs fact SUMMARY The ec2_elbs fact was deprecated when we migrated to boto3, remove it. ISSUE TYPE Feature Pull Request COMPONENT NAME elb_instance ADDITIONAL INFORMATION See also: ansible-collections#773 Reviewed-by: Alina Buzachis <None>

elb_instance - boto3 migration SUMMARY Migrate elb_instance to boto3 ISSUE TYPE Feature Pull Request COMPONENT NAME elb_instance ADDITIONAL INFORMATION Depends-On: ansible/ansible-zuul-jobs#1200 Reviewed-by: Jill R <None> Reviewed-by: Mark Chappell <None> Reviewed-by: Alina Buzachis <None> Reviewed-by: None <None>

elb_instance - remove ec2_elbs fact SUMMARY The ec2_elbs fact was deprecated when we migrated to boto3, remove it. ISSUE TYPE Feature Pull Request COMPONENT NAME elb_instance ADDITIONAL INFORMATION See also: ansible-collections#773 Reviewed-by: Alina Buzachis <None>

elb_instance - boto3 migration SUMMARY Migrate elb_instance to boto3 ISSUE TYPE Feature Pull Request COMPONENT NAME elb_instance ADDITIONAL INFORMATION Depends-On: ansible/ansible-zuul-jobs#1200 Reviewed-by: Jill R <None> Reviewed-by: Mark Chappell <None> Reviewed-by: Alina Buzachis <None> Reviewed-by: None <None>

elb_instance - remove ec2_elbs fact SUMMARY The ec2_elbs fact was deprecated when we migrated to boto3, remove it. ISSUE TYPE Feature Pull Request COMPONENT NAME elb_instance ADDITIONAL INFORMATION See also: ansible-collections#773 Reviewed-by: Alina Buzachis <None>

patchback bot mentioned this pull request Apr 13, 2022

Fix tempfolder path since Fedora uses tmpfs #590

Merged

tremble approved these changes Apr 13, 2022

View reviewed changes

ansibullbot added bug This issue/PR relates to a bug community_review integration tests/integration needs_triage new_contributor Help guide this first time contributor plugins plugin (any type) small_patch Hopefully easy to review tests tests labels Apr 13, 2022

ansibullbot removed needs_triage small_patch Hopefully easy to review labels Apr 13, 2022

tremble added the mergeit Merge the PR (SoftwareFactory) label Apr 13, 2022

softwarefactory-project-zuul bot merged commit bed4069 into stable-1.5 Apr 13, 2022

softwarefactory-project-zuul bot deleted the patchback/backports/stable-1.5/b27f5167dd9f161d46bb018fcd73eae53831930d/pr-590 branch April 13, 2022 09:27

tremble mentioned this pull request Apr 19, 2022

Fix CI for the stable-1.5 branch #685

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[PR #590/b27f5167 backport][stable-1.5] Fix tempfolder path since Fedora uses tmpfs #773

[PR #590/b27f5167 backport][stable-1.5] Fix tempfolder path since Fedora uses tmpfs #773

patchback bot commented Apr 13, 2022 •

edited by tremble

Loading

ansibullbot commented Apr 13, 2022

softwarefactory-project-zuul bot commented Apr 13, 2022

tremble commented Apr 13, 2022

softwarefactory-project-zuul bot commented Apr 13, 2022

softwarefactory-project-zuul bot commented Apr 13, 2022

[PR #590/b27f5167 backport][stable-1.5] Fix tempfolder path since Fedora uses tmpfs #773

[PR #590/b27f5167 backport][stable-1.5] Fix tempfolder path since Fedora uses tmpfs #773

Conversation

patchback bot commented Apr 13, 2022 • edited by tremble Loading

SUMMARY

ISSUE TYPE

COMPONENT NAME

ansibullbot commented Apr 13, 2022

softwarefactory-project-zuul bot commented Apr 13, 2022

tremble commented Apr 13, 2022

softwarefactory-project-zuul bot commented Apr 13, 2022

softwarefactory-project-zuul bot commented Apr 13, 2022

patchback bot commented Apr 13, 2022 •

edited by tremble

Loading