-
Notifications
You must be signed in to change notification settings - Fork 341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PR #928/524129fc backport][stable-4] ec2_instance - expand use of AWSRetry #931
Merged
softwarefactory-project-zuul
merged 1 commit into
stable-4
from
patchback/backports/stable-4/524129fcb5a8cebcea735cc0c83813205e0a160e/pr-928
Jul 15, 2022
Merged
[PR #928/524129fc backport][stable-4] ec2_instance - expand use of AWSRetry #931
softwarefactory-project-zuul
merged 1 commit into
stable-4
from
patchback/backports/stable-4/524129fcb5a8cebcea735cc0c83813205e0a160e/pr-928
Jul 15, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ec2_instance - expand use of AWSRetry SUMMARY fixes: #927 A few code paths weren't using AWSRetry when the should have, probably a leftover from when retries included the NotFound exceptions. ISSUE TYPE Feature Pull Request COMPONENT NAME ec2_instance ADDITIONAL INFORMATION Reviewed-by: Brian Scholer <None> Reviewed-by: Alina Buzachis <None> (cherry picked from commit 524129f)
ansibullbot
added
community_review
feature
This issue/PR relates to a feature request
module
module
needs_triage
new_contributor
Help guide this first time contributor
plugins
plugin (any type)
labels
Jul 15, 2022
tremble
approved these changes
Jul 15, 2022
softwarefactory-project-zuul
bot
deleted the
patchback/backports/stable-4/524129fcb5a8cebcea735cc0c83813205e0a160e/pr-928
branch
July 15, 2022 13:53
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
community_review
feature
This issue/PR relates to a feature request
mergeit
Merge the PR (SoftwareFactory)
module
module
new_contributor
Help guide this first time contributor
plugins
plugin (any type)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of PR #928 as merged into main (524129f).
SUMMARY
fixes: #927
A few code paths weren't using AWSRetry when the should have, probably a leftover from when retries included the NotFound exceptions.
ISSUE TYPE
COMPONENT NAME
ec2_instance
ADDITIONAL INFORMATION