introduced consul_systemd_service_name variable #591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nre-ableton
suggested changes
Feb 22, 2024
| @@ -94,7 +94,7 @@ | |||
| - name: Override systemd service params | |||
| ansible.builtin.template: | |||
| src: consul_systemd_service.override.j2 | |||
| dest: /etc/systemd/system/consul.service.d/override.conf | |||
| dest: "/etc/systemd/system/{{ consul_systemd_service_name }}.service.d/override.conf" | |||
There was a problem hiding this comment.
This causes an ansible-lint violation, since templating Ansible task names only works if the template is at the very end of the string. You'll need to reword the task (and drop the quotes) to make this work.
|
Can you add the new variable to the readme, please? Otherwise this looks good to me (when ansible-lint is happy). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
introduced consul_systemd_service_name variable to allow specifying name of service (and related directories), solving the issue of running multiple instances on the same machine
ISSUE TYPE