Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unstable integration tests ec2_eip #159

Closed
tremble opened this issue Jul 25, 2020 · 5 comments · Fixed by #936
Closed

Unstable integration tests ec2_eip #159

tremble opened this issue Jul 25, 2020 · 5 comments · Fixed by #936
Labels
affects_2.10 CI has_pr needs_info This issue requires further information. Please answer any outstanding questions needs_template This issue/PR has an incomplete description. Please fill in the proposed template correctly

Comments

@ansibullbot
Copy link

Files identified in the description:
None

If these files are inaccurate, please update the component name section of the description or use the !component bot command.

click here for bot help

@ansibullbot
Copy link

@tremble: Greetings! Thanks for taking the time to open this issue. In order for the community to handle your issue effectively, we need a bit more information.

Here are the items we could not find in your description:

  • issue type
  • ansible version
  • component name

Please set the description of this issue with this template:
https://raw.githubusercontent.com/ansible/ansible/devel/.github/ISSUE_TEMPLATE/bug_report.md

click here for bot help

@jatorcasso
Copy link
Contributor

@tremble @jillr @alinabuzachis what's a good way to validate that this is fixed? I updated the integration tests and am not running into this issue, but unsure if it's actually fixed or not

@alinabuzachis
Copy link
Contributor

@tremble @jillr @alinabuzachis what's a good way to validate that this is fixed? I updated the integration tests and am not running into this issue, but unsure if it's actually fixed or not

I would probably go through the CI logs tremble listed there and check if that issues are solved or still happen with your changes.

@jatorcasso
Copy link
Contributor

Thanks! I didn't run into any of those failures so I'll go ahead and link it

softwarefactory-project-zuul bot pushed a commit that referenced this issue Feb 16, 2022
Stabilize ec2_eip module

SUMMARY

fixed check_mode issues
added integration tests for check_mode / idempotency
updated json returned when state = absent for clarity
removed json_query references
fixes #159

Depends-On: ansible-collections/amazon.aws#672
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
ec2_eip

Reviewed-by: Mark Woolley <[email protected]>
Reviewed-by: Mark Chappell <None>
Reviewed-by: Alina Buzachis <None>
Reviewed-by: Joseph Torcasso <None>
Reviewed-by: Jill R <None>
softwarefactory-project-zuul bot pushed a commit that referenced this issue Feb 23, 2022
backport-3: Stabilize ec2_eip module (#936) 

Backport into stable-3 of #936 with commit id: d0596e3
SUMMARY
fixed check_mode issues
added integration tests for check_mode / idempotency
updated json returned when state = absent for clarity
removed json_query references
fixes #159
Depends-On: ansible-collections/amazon.aws#672
ISSUE TYPE
Feature Pull Request
COMPONENT NAME
ec2_eip
Reviewed-by: Mark Woolley 
Reviewed-by: Mark Chappell 
Reviewed-by: Alina Buzachis 
Reviewed-by: Joseph Torcasso 
Reviewed-by: Jill R 
SUMMARY


ISSUE TYPE


Bugfix Pull Request
Docs Pull Request
Feature Pull Request
New Module Pull Request

COMPONENT NAME

ADDITIONAL INFORMATION
alinabuzachis pushed a commit to alinabuzachis/community.aws that referenced this issue May 25, 2022
…ble-collections#159)

* Add is_boto3_errror_message partner to is_boto3_errror_code

Amazon has some examples where the exceptions they return are very
broad.  Where we want to special case behaviour for specific failure
modes it_boto3_error_message can help avoid the need to re-raise the
exception and mess with the tracebacks.

* Add specific examples for is_boto3_error_message

* Add initial unit tests for is_boto3_error_message()
abikouo pushed a commit to abikouo/community.aws that referenced this issue Oct 24, 2023
Stabilize ec2_eip module

SUMMARY

fixed check_mode issues
added integration tests for check_mode / idempotency
updated json returned when state = absent for clarity
removed json_query references
fixes ansible-collections#159

Depends-On: ansible-collections/amazon.aws#672
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
ec2_eip

Reviewed-by: Mark Woolley <[email protected]>
Reviewed-by: Mark Chappell <None>
Reviewed-by: Alina Buzachis <None>
Reviewed-by: Joseph Torcasso <None>
Reviewed-by: Jill R <None>

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections@d0596e3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects_2.10 CI has_pr needs_info This issue requires further information. Please answer any outstanding questions needs_template This issue/PR has an incomplete description. Please fill in the proposed template correctly
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants