Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support "Drop invalid header fields" in elb_application_lb #571

Closed
boutetnico opened this issue May 7, 2021 · 5 comments · Fixed by #963
Closed

Support "Drop invalid header fields" in elb_application_lb #571

boutetnico opened this issue May 7, 2021 · 5 comments · Fixed by #963
Labels
feature This issue/PR relates to a feature request module module plugins plugin (any type) waiting_on_contributor Needs help. Feel free to engage to get things unblocked

Comments

@boutetnico
Copy link
Contributor

SUMMARY

Add support for "drop invalid header fields" when manipulating an ALB.

ISSUE TYPE
  • Feature Idea
COMPONENT NAME

elb_application_lb

ADDITIONAL INFORMATION

If you want to enable dropping invalid headers on your ALB you should:

  • create the ALB
  • by default, dropping invalid headers is disabled
  • edit the ALB settings on AWS UI and enable "Drop invalid header fields"

This feature would solve the need to manually edit the ALB after its creation.



      		
    

      
  





        



            

              
            

        

      


      
    








      

    



      

  
      



  

  @alinabuzachis





  


    

      

  

    

        
    
    

  


      
          
  
      
            Copy link

  

      
    

  


  

      

  
    Contributor


      

  


  

    

  





      


        


  
    

      
          
Hi @boutetnico, thank you for raising this. Would you be willing to implement this feature? If you need any help, please feel free to reach out to us on IRC #ansible-aws. Thank you.

      		
    

  





        


            

            

              
            

        

      


      

            
  

    
  
    
    

  

  



    












      

  
      



  

  @ansibullbot





  


    

      

  

    

        
    
    

  


      
          
  
      
            Copy link

  

      
    

  


  

      



      

  


  

    

  





      


        


  
    

      
          
cc @jillr @s-hertel @tremble @wimnat

click here for bot help


      		
    

  





        


            

            

              
            

        

      


      

            
  

    
  
    
    

  

  



    












      

  
            

    

      
    

    


      

          @ansibullbot
ansibullbot




            added
      

  feature

  This issue/PR relates to a feature request

      

  module

  module

      

  needs_triage


      

  plugins

  plugin (any type)

  labels


      Jun 30, 2021

    

  



    

    

      
    

    


      

          @jillr
jillr




            added
      

  waiting_on_contributor

  Needs help. Feel free to engage to get things unblocked

    and removed
      

  needs_triage


  labels


      Jul 27, 2021

    

  








      

  
      



  

  @ansibullbot





  


    

      

  

    

        
    
    

  


      
          
  
      
            Copy link

  

      
    

  


  

      



      

  


  

    

  





      


        


  
    

      
          
cc @markuman

click here for bot help


      		
    

  





        


            

            

              
            

        

      


      

            
  

    
  
    
    

  

  



    












      

  
          

  

    
  


  

      

    @markuman
markuman



    mentioned this issue
    
      Feb 1, 2022
    





  


  

      
  
  Closed

  





  
  

      
        
      
      

  
    
    
  


    1 task
  





  









      

  
      



  

  @jatorcasso





  


    

      

  

    

        
    
    

  


      
          
  
      
            Copy link

  

      
    

  


  

      

  
    Contributor


      

  


  

    

  





      


        


  
    

      
          
I can work on adding this

      		
    

  





        


            

            

              
            

        

      


      

            
  

    
  
    
    

  

  



    












      

  
      



  

  @jatorcasso





  


    

      

  

    

        
    
    

  


      
          
  
      
            Copy link

  

      
    

  


  

      

  
    Contributor


      

  


  

    

  





      


        


  
    

      
          
Also going to add support for the other routing options:


    

  • http_desync_mitigation_mode
    • 

  • http_drop_invalid_header_fields (this issue)
    • 

  • http_x_amzn_tls_version_and_cipher_suite
    • 

  • http_xff_client_port_enabled
    • 


      		
    

  





        


            

            

              
            

        

      


      

            
  

    
  
    
    

  

  



    












      

  
          

  

    
  


  

      

    @jatorcasso
jatorcasso



    mentioned this issue
    
      Mar 4, 2022
    





  


  

      
   Merged

  







  




    

    


  


  
    
  
  

    
  softwarefactory-project-zuul bot

      pushed a commit
      that referenced
      this issue

    
      Mar 26, 2022
    
    

      


  

    

      


  

      
        @jatorcasso
  





      

        
          elb_application_lb - support alb attributes (#963)
        

          
            
          

      


      

          

    
    
    

  

    


      


      

      


      
      

        
          85bfce4
        
      

    

  

    

      
elb_application_lb - support alb attributes

SUMMARY

Support modifying different alb specific attributes
Fixes #571
Depends-On ansible-collections/amazon.aws#696

ISSUE TYPE

Feature Pull Request

COMPONENT NAME
elb_application_lb

Reviewed-by: Jill R <None>
Reviewed-by: Markus Bergholz <[email protected]>
Reviewed-by: Alina Buzachis <None>
Reviewed-by: Joseph Torcasso <None>

    




    

  




  


  
    
  
  

    
  jatorcasso 

      added a commit
        to jatorcasso/community.aws
      that referenced
      this issue

    
      Mar 28, 2022
    
    

      


  

    

      


  

      
        @jatorcasso
  





      

        
          elb_application_lb - support alb attributes (ansible-collections#963)
        

          
            
          

      


      

          

    
    
    

  

      


      

      


      
      

        
          4089911
        
      

    

  

    

      
elb_application_lb - support alb attributes

SUMMARY

Support modifying different alb specific attributes
Fixes ansible-collections#571
Depends-On ansible-collections/amazon.aws#696

ISSUE TYPE

Feature Pull Request

COMPONENT NAME
elb_application_lb

Reviewed-by: Jill R <None>
Reviewed-by: Markus Bergholz <[email protected]>
Reviewed-by: Alina Buzachis <None>
Reviewed-by: Joseph Torcasso <None>
(cherry picked from commit 85bfce4)

    




    

  




  


  
    
  
  

    
  alinabuzachis 

      added a commit
        to alinabuzachis/community.aws
      that referenced
      this issue

    
      May 25, 2022
    
    

      


  

    

      


  

      
        @alinabuzachis
  





      

        
          Add missing RETURN data in docs (ansible-collections#571)
        

          
            
          

      


      

          

    
    
    

  

    


      


      

      


      
      

        
          2fded7e
        
      

    

  

    

      
Docs s3_bucket

SUMMARY

Add RETURN docs s3_bucket.

ISSUE TYPE


Docs Pull Request

COMPONENT NAME

s3_bucket

Reviewed-by: Mark Chappell <None>
Reviewed-by: None <None>

    




    

  













  
  

    

      

  





  




  
  

              

  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment


  



  






  
                  




    

  


      
  

    Assignees
  



        

    No one assigned







      


  


  

    Labels
  



    

      

    feature

  This issue/PR relates to a feature request
  

    module

  module
  

    plugins

  plugin (any type)
  

    waiting_on_contributor

  Needs help. Feel free to engage to get things unblocked








      

  

    

        

    Projects
  


        




    None yet




  



      


  

    
  

    Milestone
  


      No milestone





    
      
          


  

    
      

        
    

    Development
  




            
Successfully merging a pull request may close this issue.





    


  
          
      elb_application_lb - support alb attributes

    
      jatorcasso/community.aws
    





    
  




        
      

    

  
      

  

    

      5 participants
    

    

        
          @boutetnico 
        
          @jillr 
        
          @alinabuzachis 
        
          @ansibullbot 
        
          @jatorcasso